As a user, I need to see charts/graphs of my lab values related to my stage of CKD

dustinWeaver commented 6 years ago

On the charts screen, chart the lab values that the user has collected. The user should get a list based on this spreadsheet corresponding with the CKD stage.

The user should also have the option of showing any lab values they may choose.

The data should be read from Health Kit as appropriate.

seriyvolk83 commented 6 years ago

Can we use external Charts framework for that? The design may differ from the implementation though.

dustinWeaver commented 6 years ago

We can use an external chart framework.

seriyvolk83 commented 6 years ago

We need to show one chart or two like now?

There will be two plots in the chart: "Goals", "Actual".

May be it should be "Goal" because for each lab value can have one goal?
Will the goal plot be a strait line if it's not changed? Current stub image shows very wriggling plot for "Goals".

seriyvolk83 commented 6 years ago

The user should also have the option of showing any lab values they may choose.

Currently all lab values are shown at the top and can be selected one-by-one. We can add "Other" option to the end of the list to allow user to select any lab value. Is it what you expect?
Do we hardcode the complete list of all possible lab values that user can select? Or we obtain the possible lab values from HealthKit? (not sure yet if it's possible, but seems more correct)
After user choose "Other" and selects extra lab value, then should we save this selection and show the lab value at the top the next time user opens Charts? If yes (save), then can we skip adding option to delete the added new lab value because it will require new UI and maybe the flow will be changed in future.

dustinWeaver commented 6 years ago

@seriyvolk83, answers below:

Just one chart per lab value
"Goal" is correct.
The plot should just be straight for the goal
This screen actually seems a bit messy like this. Would be nice to have all the selected labs on one screen. Then have a button to allow the user to check/uncheck values they wish to see
If we can get it from HealthKit, that would be preferred. Otherwise we'll need to hardcode for now
See my other comment concerning the UI. What we have now might be a bit messy

seriyvolk83 commented 6 years ago

According to the above we need to:

show lab values as a list;
show chart for each lab value.

I think the best way is to show a table will all (!) possible lab values, but separate them into two sections:

lab values corresponding to CKD stage (section title "Major");
other lab values from HealthKit (section title "Other"). The initial collection at the top is removed (because is replaced by the table). When user will tap on a lab value, the chart screen will be presented as details (push transition type).

Can you confirm this?

talesforce commented 6 years ago

Confirmed

On Sat, Mar 3, 2018 at 6:26 PM, seriyvolk83 notifications@github.com wrote:

According to the above we need to:

show lab values as a list;

show chart for each lab value.

I think the best way is to show a table will all possible lab values, but separate them into two sections:

lab values corresponding to CKD stage (section title "Major");

other lab values from HealthKit (section title "Other"). The initial collection at the top is removed (because is replaced by the table). When user will tap on a lab value, the chart screen will be presented as details (push transition type).

Can you confirm this?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/topcoderinc/va-kidney-ios/issues/18#issuecomment-370145695, or mute the thread https://github.com/notifications/unsubscribe-auth/AB7vceBArVoTuVnHDlQunNMelxA69Vz3ks5tapMEgaJpZM4ST5cX .

--

Regards,

Talesforce Co-pilot/ Reviewer/ Ex-Community Advisory Board talesforce@topcoder.com / admin@talesforce.com

www.topcoder.com http://topcoder.com/ / topcoder.com/blog / @Topcoder https://twitter.com/topcoder 760 Market Street, 11th Floor, San Francisco, CA 94102

sdgun commented 6 years ago

'Alchohol' Lab values is not working, can't add a record using the '+' option
Can't see any data related to 'Goal' only entered values are displayed on the chart. For example, if we set a Goal for Water intake and Add an actual value from (+) add button won't render the chart

sdgun commented 6 years ago

Fixed as per the comment https://github.com/topcoderinc/va-kidney-ios/issues/18#issuecomment-370145695

topcoderinc / va-kidney-ios

As a user, I need to see charts/graphs of my lab values related to my stage of CKD #18