search

topcoderinc / va-kidney-ios

Mobile Kidney App for VA
2 stars 2 forks source link

Code Quality Issue - typealias Recommendation = MedicationResource #43

Closed talesforce closed 6 years ago

talesforce commented 6 years ago

From previous challenge review

I don't see this as a role disambiguation, looks just as a shortcut to connect logic parts

LieutenantRoger commented 6 years ago

so to update the code to use MedicationResource directly ?

N1k1tung commented 6 years ago

yes, you may also refactor the name to describe the exact role better

seriyvolk83 commented 6 years ago

The alias was added because MedicationResource name does not match the class role. So, no, the code should not use it. The class should be renamed to Recommendation. @N1k1tung , agree?

talesforce commented 6 years ago

@seriyvolk83 - Yes, what you have suggested is fine, let's go with that