topcoderinc / va-kidney-ios

Mobile Kidney App for VA
2 stars 2 forks source link

FDA & USDA services should be effectively cached #44

Closed talesforce closed 6 years ago

talesforce commented 6 years ago

As noted from previous challenge review -

FDA & USDA services should be effectively cached since they are available with rate limits. Though the rates are per hour per IP, and provide a fair amount of requests so it should likely suffice for general usage

LieutenantRoger commented 6 years ago

1) Do you mean to cache the FDA result per request , if so what's the expire time ? 2) What's USDA service ?

N1k1tung commented 6 years ago
  1. use cache headers if available https://tools.ietf.org/html/rfc5861 https://tools.ietf.org/html/rfc7234
  2. named ndb in code. https://ndb.nal.usda.gov/ Full name is USDA National Nutrient Database
talesforce commented 6 years ago

Closing, this is working well