topcoderinc / va-kidney-ios

Mobile Kidney App for VA
2 stars 2 forks source link

Change Food Intake screen to allow better food entry #7

Closed dustinWeaver closed 6 years ago

dustinWeaver commented 6 years ago

Currently the food intake screen takes a comma separated list of items, but only offers a single amount and unit of measurement. This would not work for most meals as an individual may have multiple items in a single meal.

As such, we should make a "add food item" button within the intake form to allow users to continuously add food items to a meal. We should move the amount and unit fields to this new form.

On the intake form, we can change to a table or list of the items entered. Allowing a user easy ways to edit/delete items.

seriyvolk83 commented 6 years ago

@talesforce Please merge the last changes. Looks like everything is done.

talesforce commented 6 years ago

I will check in a few hours

On Fri, 23 Feb 2018 at 10:41 PM, seriyvolk83 notifications@github.com wrote:

@talesforce https://github.com/talesforce Please merge the last changes. Looks like everything is done.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/topcoderinc/va-kidney-ios/issues/7#issuecomment-368073970, or mute the thread https://github.com/notifications/unsubscribe-auth/AB7vcXXUnpN3_V59OcNTPv_aD_Td3x30ks5tXvFAgaJpZM4SEgd5 .

-- Sent from Gmail Mobile

dustinWeaver commented 6 years ago

Just a couple of changes:

  1. Change the "Add Meal" to read "Add Food Item"

  2. Create a way for the user to cancel out of modal "Add Meal" box

seriyvolk83 commented 6 years ago

@dustinWeaver @talesforce

2

There is white "X" button on top right corner of the popup. I have no appropriate icon and made it with letter "X".

What do you think?

seriyvolk83 commented 6 years ago

1

I assume it's about the button name in the new popup. "ADD NEW MEAL" -> "ADD FOOD ITEM", correct?

talesforce commented 6 years ago

I believe so - let's proceed with that.

On Sat, Feb 24, 2018 at 7:39 PM, seriyvolk83 notifications@github.com wrote:

1

I assume it's about the button name in the new popup. "ADD NEW MEAL" -> "ADD FOOD ITEM", correct?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/topcoderinc/va-kidney-ios/issues/7#issuecomment-368230850, or mute the thread https://github.com/notifications/unsubscribe-auth/AB7vcX285kH66k0ZAXPY4JGiaDdS8abvks5tYBgwgaJpZM4SEgd5 .

--

Regards,

Talesforce Co-pilot/ Reviewer/ Ex-Community Advisory Board talesforce@topcoder.com / admin@talesforce.com

www.topcoder.com http://topcoder.com/ / topcoder.com/blog / @Topcoder https://twitter.com/topcoder 760 Market Street, 11th Floor, San Francisco, CA 94102

seriyvolk83 commented 6 years ago

Done

talesforce commented 6 years ago

@dustinWeaver - Is this one okay in the last build that I released to you?

dustinWeaver commented 6 years ago

Yes, looks good now. Thank you!