search

topcoderinc / va-pseudovet

pseudovet Project For VA
1 stars 1 forks source link

Changing the 'OUTPUT FORMAT' won't reflect on the 'OUTPUT FORMAT' column in Generated Datasets section #51

Open sdgun opened 6 years ago

sdgun commented 6 years ago

Target URL

http://127.0.0.1:5000/dashboard

Steps to Reproduce

  1. Open the URL http://127.0.0.1:5000/
  2. Click 'Generate Dataset' from one of the items from Dashboard [Configurations]
  3. Now from the 'Generated Datasets' list select one item > Edit Config
  4. Go to the last screen and change the OUTPUT FORMAT (FHIR-XML > FHIR-JSON)
  5. Click SAVE
  6. In the dashboard check the column 'OUTPUT FORMAT'

Actual Result(s)

Expected Result(s)

Frequency

Environment Details

Image(s)/Video(s)/Console Log/Crash Log

https://www.screencast.com/t/y9qvrdFtGRtd

jiangliwu commented 6 years ago

@sdgun you misunderstood this, Generated Dataset will never updated again when dataset generated from Configurations, you need reGenerate Dataset when configuration updated.

dustinWeaver commented 6 years ago

@jiangliwu, what would it take to make the generation asynchronous? In other words, when a user clicks "generate dataset", the modal closes and we have a "generating" status. We'd need to add the "status" column to the table as well. Could make the values "complete", "generating".

cc: @ksmacleod99

jiangliwu commented 6 years ago

@dustinWeaver a. for asynchronous mode, i think this is no problem, but this feature need more time, and are you answering for this issue https://github.com/topcoderinc/va-pseudovet/issues/50? b. for this issue, Generated Dataset format type will not changed if generate completed.

dustinWeaver commented 6 years ago

@jiangliwu, you're correct. Not sure how my comment got posted here.

Please let us know on Slack your estimated cost to make this change.

Cc: @ksmacleod99