topdownproteomics / sdk

Software solution for common top-down proteomics tasks
http://www.topdownproteomics.org/
MIT License
9 stars 4 forks source link

Descriptor value for RESID #109

Closed rfellers closed 1 year ago

rfellers commented 1 year ago

Makes RESID consistent in parser with other modification sets, related to #108

codecov[bot] commented 1 year ago

Codecov Report

Merging #109 (7a07339) into master (f23a229) will decrease coverage by 0.06%. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/topdownproteomics/sdk/pull/109/graphs/tree.svg?width=650&height=150&src=pr&token=T8Kf00TGxl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=topdownproteomics)](https://codecov.io/gh/topdownproteomics/sdk/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=topdownproteomics) ```diff @@ Coverage Diff @@ ## master #109 +/- ## ========================================== - Coverage 84.68% 84.62% -0.06% ========================================== Files 102 102 Lines 5544 5542 -2 ========================================== - Hits 4695 4690 -5 - Misses 849 852 +3 ``` | [Impacted Files](https://codecov.io/gh/topdownproteomics/sdk/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=topdownproteomics) | Coverage Δ | | |---|---|---| | [src/TopDownProteomics/ProForma/ProFormaParser.cs](https://codecov.io/gh/topdownproteomics/sdk/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=topdownproteomics#diff-c3JjL1RvcERvd25Qcm90ZW9taWNzL1Byb0Zvcm1hL1Byb0Zvcm1hUGFyc2VyLmNz) | `95.95% <100.00%> (-0.03%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://codecov.io/gh/topdownproteomics/sdk/pull/109/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=topdownproteomics)
rfellers commented 1 year ago

thanks all, that was quick!