topdownproteomics / sdk

Software solution for common top-down proteomics tasks
http://www.topdownproteomics.org/
MIT License
9 stars 4 forks source link

Proteoform Modification Evidence #112

Closed rfellers closed 7 months ago

rfellers commented 7 months ago

Adds an Evidence enum to the proteoform modification ontology interface so one can tell where the modification came from downstream.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (c5d5b54) 85.03% compared to head (54f7ba5) 85.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/topdownproteomics/sdk/pull/112/graphs/tree.svg?width=650&height=150&src=pr&token=T8Kf00TGxl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=topdownproteomics)](https://app.codecov.io/gh/topdownproteomics/sdk/pull/112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=topdownproteomics) ```diff @@ Coverage Diff @@ ## master #112 +/- ## ========================================== - Coverage 85.03% 85.00% -0.03% ========================================== Files 102 102 Lines 5546 5549 +3 Branches 858 858 ========================================== + Hits 4716 4717 +1 - Misses 670 672 +2 Partials 160 160 ``` | [Files](https://app.codecov.io/gh/topdownproteomics/sdk/pull/112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=topdownproteomics) | Coverage Δ | | |---|---|---| | [...mics/ProForma/Validation/BrnoModificationLookup.cs](https://app.codecov.io/gh/topdownproteomics/sdk/pull/112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=topdownproteomics#diff-c3JjL1RvcERvd25Qcm90ZW9taWNzL1Byb0Zvcm1hL1ZhbGlkYXRpb24vQnJub01vZGlmaWNhdGlvbkxvb2t1cC5jcw==) | `86.30% <86.76%> (-1.20%)` | :arrow_down: | | [...mics/ProForma/Validation/ModificationLookupBase.cs](https://app.codecov.io/gh/topdownproteomics/sdk/pull/112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=topdownproteomics#diff-c3JjL1RvcERvd25Qcm90ZW9taWNzL1Byb0Zvcm1hL1ZhbGlkYXRpb24vTW9kaWZpY2F0aW9uTG9va3VwQmFzZS5jcw==) | `83.82% <84.12%> (-1.03%)` | :arrow_down: |