topdownproteomics / sdk

Software solution for common top-down proteomics tasks
http://www.topdownproteomics.org/
MIT License
9 stars 4 forks source link

Negative Mode and Charge Carriers #114

Closed rfellers closed 4 months ago

rfellers commented 5 months ago

adds better support for negative charges and custom charge carriers for Mercury7

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 88.88889% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 89.08%. Comparing base (fb4b105) to head (9c8b3ae). Report is 14 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/topdownproteomics/sdk/pull/114/graphs/tree.svg?width=650&height=150&src=pr&token=T8Kf00TGxl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=topdownproteomics)](https://app.codecov.io/gh/topdownproteomics/sdk/pull/114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=topdownproteomics) ```diff @@ Coverage Diff @@ ## master #114 +/- ## ========================================== + Coverage 85.00% 89.08% +4.07% ========================================== Files 102 103 +1 Lines 5549 5697 +148 Branches 858 878 +20 ========================================== + Hits 4717 5075 +358 + Misses 672 457 -215 - Partials 160 165 +5 ``` | [Files](https://app.codecov.io/gh/topdownproteomics/sdk/pull/114?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=topdownproteomics) | Coverage Δ | | |---|---|---| | [...cs/MassSpectrometry/ChargedIsotopicDistribution.cs](https://app.codecov.io/gh/topdownproteomics/sdk/pull/114?src=pr&el=tree&filepath=src%2FTopDownProteomics%2FMassSpectrometry%2FChargedIsotopicDistribution.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=topdownproteomics#diff-c3JjL1RvcERvd25Qcm90ZW9taWNzL01hc3NTcGVjdHJvbWV0cnkvQ2hhcmdlZElzb3RvcGljRGlzdHJpYnV0aW9uLmNz) | `65.62% <80.00%> (+5.62%)` | :arrow_up: | | [src/TopDownProteomics/Utility.cs](https://app.codecov.io/gh/topdownproteomics/sdk/pull/114?src=pr&el=tree&filepath=src%2FTopDownProteomics%2FUtility.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=topdownproteomics#diff-c3JjL1RvcERvd25Qcm90ZW9taWNzL1V0aWxpdHkuY3M=) | `65.78% <88.88%> (-0.88%)` | :arrow_down: | | [...roteomics/MassSpectrometry/IsotopicDistribution.cs](https://app.codecov.io/gh/topdownproteomics/sdk/pull/114?src=pr&el=tree&filepath=src%2FTopDownProteomics%2FMassSpectrometry%2FIsotopicDistribution.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=topdownproteomics#diff-c3JjL1RvcERvd25Qcm90ZW9taWNzL01hc3NTcGVjdHJvbWV0cnkvSXNvdG9waWNEaXN0cmlidXRpb24uY3M=) | `50.00% <58.33%> (-12.97%)` | :arrow_down: | | [src/TopDownProteomics/Tools/Mercury7.cs](https://app.codecov.io/gh/topdownproteomics/sdk/pull/114?src=pr&el=tree&filepath=src%2FTopDownProteomics%2FTools%2FMercury7.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=topdownproteomics#diff-c3JjL1RvcERvd25Qcm90ZW9taWNzL1Rvb2xzL01lcmN1cnk3LmNz) | `93.02% <92.37%> (-0.51%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/topdownproteomics/sdk/pull/114/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=topdownproteomics)