topepo / FES

Code and Resources for "Feature Engineering and Selection: A Practical Approach for Predictive Models" by Kuhn and Johnson
https://bookdown.org/max/FES
GNU General Public License v2.0
724 stars 237 forks source link

Figure 6.5: knots are not plotted #101

Closed agarci closed 3 years ago

agarci commented 3 years ago

In the version dated "2019-06-21", the Figure 6.5 description refers to the lines representing the knots (the blue lines) as:

(a) Features created using a natural spline basis function for the lot area predictor. The blue lines correspond to the knots. (b) The fit after the regression model estimated the model coefficients for each feature.

But in this figure (6.5) the knots are not represented in the plot at all. They are represented in the previous figure, 6.4, and it is not so easy to match the lines. Besides, in the printed version of the book they are in different pages.

agarci commented 3 years ago

Sorry, this issue is already reported in Codes for Section 6.2 are missing.

Nice book, thank you.