search

topepo / FES

Code and Resources for "Feature Engineering and Selection: A Practical Approach for Predictive Models" by Kuhn and Johnson
https://bookdown.org/max/FES
GNU General Public License v2.0
724 stars 237 forks source link

Version: 2018-09-08 Section: 4.3.1 : Possible typos or errors #52

Closed mpettis closed 5 years ago

mpettis commented 5 years ago

Version: 2018-09-08 Section: 4.3.1 Visualizing Relationships between Outcomes and Predictors

  1. Very minor typo, missing posessive apostrophe on profiles, and I think I did it right, but should be checked. I believe this:

As an example, total length of all the profiles essays will be used to illustrate a possible solution.

should be this

As an example, total length of all the profiles' essays will be used to illustrate a possible solution.

  1. Wrong value quoted in text?

The maximum length was approximately 0K characters although 10% of the profiles contained less than 14 characters.

The charts make me think it should be at least 100, possibly 1K, based on next issue.

  1. Wrong value referenced?

Prior to a length of 10^3.5, the profile is slightly less likely than chance to be STEM.

From the plot it is referring to, I'm reading that statement to refer to the point where the black line in 4.15(b) crosses the horizontal red baseline value. According to that chart, that occurs at 10^1.5, not 10^3.5. Otherwise, 10^3.5 is not show on the chart, and I assume was an extrapolation.

topepo commented 5 years ago

I had previously gotten two of these but missed the last one. Thanks.

We might publish a new (final-ish) version Friday so let us know if you find anything else.