topepo / FES

Code and Resources for "Feature Engineering and Selection: A Practical Approach for Predictive Models" by Kuhn and Johnson
https://bookdown.org/max/FES
GNU General Public License v2.0
724 stars 237 forks source link

Date: 2019-02-22, Chapter 2 / Table 2.3 #70

Closed bashhwu closed 5 years ago

bashhwu commented 5 years ago

Thanks for giving us feedback on the book. Please follow these guidelines:

Comments or questions on the content

Please tell us where exactly the issue is (e.g. chapter, section, figure number, etc.) and, whenever possible, copy/paste the text in question using > in the issue. Also, please state the version of the book by referencing the date on the book's first page (under the title and authors).

See this issue as an example:

In the version dated "2018-05-12", capitalization in article/book names are inconsistent. Also, sometimes initials are used for names, sometimes not: 

> Agresti, Alan. 2012. Categorical Data Analysis. Wiley-Interscience.
> Altman, D. 1991. “Categorising Continuous Variables.” British Journal of Cancer, no. 5:975.

Thanks for the great book.

I believe that table 2.3 is produced using a small training dataset which contains 89 patients. Have you used 10-fold cross-validation to compute the P-values for the risk predictors?

When 5-fold cross validation is used, a different result is yielded (for HypercholesterolemiaHistory). Could you please advise me on this (What is the optimal value of K when the dataset is small)?