topepo / FES

Code and Resources for "Feature Engineering and Selection: A Practical Approach for Predictive Models" by Kuhn and Johnson
https://bookdown.org/max/FES
GNU General Public License v2.0
716 stars 237 forks source link

Chapter 6, 9, 10, 12 typos. Version 2019-06-21 #94

Open hhp94 opened 4 years ago

hhp94 commented 4 years ago

In the version dated "2019-06-21", there are two typos in Chapter 6.

The first typo is in the introduction page for Chapter 6. Second paragraph from the bottom, first sentence. "organizedinto" should be "organized into".

The techniques in this chapter have been organizedinto three general categories .

The second typo is in Section 6.2.2. In figure 6.5, the figure's caption is using the caption of figure 6.4 instead of the ones for MARS splines.

Figure 6.5: (a) Features created using a natural spline basis function for the lot area predictor. The blue lines correspond to the knots. (b) The fit after the regression model estimated the model coefficients for each feature.

Awesome book. Thank you so much.

hhp94 commented 4 years ago

Chapter 9 Working with Profile Data, third paragraph: It should be "recall that there are also weather measurements..." instead of "recall they there are also..."

However, recall they there are also weather measurements. The weather data was obtained multiple times per day, usually hourly.

Chapter 10.2 Classes of Feature Selection Methodologies, "mythologies" should have been "methodologies".

Feature selection mythologies fall into three general classes: intrinsic (or implicit) methods, filter methods, and wrapper methods.

Chapter 12.2.1 Selecting Features without Overfitting, third paragraph: "If the external analysis set, which is 90% of the training set, is larger enough we might..." Do you mean "large enough" instead?

If the external analysis set, which is 90% of the training set, is larger enough we might use a random 80% of these data for modeling and 20% for evaluation.

Again, thank you. Big fan.