search

topeterk / HitCounterManager

Free Hit Counter / Death Counter that is running in the background, so you can focus on your stream. No need to keep any windows open for a window capture any more. Initially designed for Dark Souls and similar games but supports any game.
MIT License
87 stars 19 forks source link

PB hits just stop on first split with hit #22

Closed hielfx closed 3 years ago

hielfx commented 3 years ago

How can I set the behahiour so the PB will display like this:

splits

I'm talking about the PB hit colum. In my case, the PB colum just stops on the first split with hits, i.e., all of the next splits, even if they don't have a hit, will be crossed instead of checked. In the image example, all of them will be crossed after the dancer hit.

EDIT: Adding an example file of the case I'm talking about

output

topeterk commented 3 years ago

Hi, a refactoring of the HTML file brought this issue into version 1.20.

Crossing the PB after the "first" hit should only be done when the purpose option is set to "NoDeath". You should be able to fix this by opening the file Designs/HitCounterGui.html, find... ShowCrossOrCheckMark(s.hitless_pb ? s.hits_pb : 1)) and replace it with ShowCrossOrCheckMark(d.purpose == 3 && !s.hitless_pb ? 1 : s.hits_pb))

I'll add this fix to the next version. Thanks for the feedback ;)