search

topfreegames / maestro

Maestro: Game Room Scheduler
MIT License
115 stars 15 forks source link

refactor(healthcontroller): cap maxSurge and compute based on total #631

Closed hspedro closed 3 months ago

hspedro commented 3 months ago

Currently, the rolling update strategy is always upscaling maxSurge amount in the health controller. We need to cap this amount to consider desiredRooms + maxSurge - len(availableRooms)

codecov-commenter commented 3 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.58%. Comparing base (bb118c8) to head (9f4dd35). Report is 12 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #631 +/- ## =========================================== + Coverage 64.30% 80.58% +16.27% =========================================== Files 39 85 +46 Lines 2905 5917 +3012 =========================================== + Hits 1868 4768 +2900 - Misses 909 941 +32 - Partials 128 208 +80 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.