search

topfreegames / maestro

Maestro: Game Room Scheduler
MIT License
115 stars 15 forks source link

feat(metrics): report scheduler readyTarget #642

Closed hspedro closed 1 month ago

hspedro commented 1 month ago

This metric is useful for creating dynamic graphs, with visual lines representing the readyTarget or targetOccupancy, and also to create budget representations of how much we deviated above and below the target.

New metric name: maestro_next.ready_target

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.12%. Comparing base (bb118c8) to head (1928f6b). Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
internal/core/worker/metricsreporter/metrics.go 0.00% 2 Missing :warning:
.../worker/metricsreporter/metrics_reporter_worker.go 77.77% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #642 +/- ## =========================================== + Coverage 64.30% 81.12% +16.82% =========================================== Files 39 85 +46 Lines 2905 5887 +2982 =========================================== + Hits 1868 4776 +2908 + Misses 909 905 -4 - Partials 128 206 +78 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.