Closed bruce1125 closed 6 months ago
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
groups/memory_group_service.go | 1 | 84.25% | ||
cluster/nats_rpc_client.go | 10 | 84.81% | ||
<!-- | Total: | 11 | --> |
Totals | |
---|---|
Change from base Build 8807700949: | 0.04% |
Covered Lines: | 4833 |
Relevant Lines: | 7779 |
FYI new version released with this change: https://github.com/topfreegames/pitaya/releases/tag/v2.11.0
LGTM. We should create a helper later like, a new method in the interface like: RPC(msg, route, ..., timeout) which sets this value on the context, so that this feature would be easier accessible and we avoid unmarshal errors on the timeout value
That's a good idear, waiting for the new API.
update docs to explain how to customize the timeout value