topfreegames / pitaya

Scalable game server framework with clustering support and client libraries for iOS, Android, Unity and others through the C SDK.
MIT License
2.35k stars 482 forks source link

Feat/customize rpc timeout #393

Closed bruce1125 closed 6 months ago

bruce1125 commented 6 months ago

update docs to explain how to customize the timeout value

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 8812929899

Details


Files with Coverage Reduction New Missed Lines %
groups/memory_group_service.go 1 84.25%
cluster/nats_rpc_client.go 10 84.81%
<!-- Total: 11 -->
Totals Coverage Status
Change from base Build 8807700949: 0.04%
Covered Lines: 4833
Relevant Lines: 7779

💛 - Coveralls
felipejfc commented 6 months ago

FYI new version released with this change: https://github.com/topfreegames/pitaya/releases/tag/v2.11.0

bruce1125 commented 6 months ago

LGTM. We should create a helper later like, a new method in the interface like: RPC(msg, route, ..., timeout) which sets this value on the context, so that this feature would be easier accessible and we avoid unmarshal errors on the timeout value

That's a good idear, waiting for the new API.