topfreegames / pitaya

Scalable game server framework with clustering support and client libraries for iOS, Android, Unity and others through the C SDK.
MIT License
2.38k stars 480 forks source link

Fix/observability gaps #406

Closed renatoaf closed 5 months ago

renatoaf commented 5 months ago
felipejfc commented 5 months ago

@renatoaf idk if it was with these changes, but the unit tests are failing, I've already re-ran they 3 times but no luck. can you check before merging?

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9668461825

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
agent/agent.go 41 43 95.35%
cluster/nats_rpc_server.go 2 4 50.0%
service/handler.go 0 5 0.0%
<!-- Total: 44 53 83.02% -->
Totals Coverage Status
Change from base Build 8848487306: 0.2%
Covered Lines: 4875
Relevant Lines: 7864

💛 - Coveralls
renatoaf commented 5 months ago

@renatoaf idk if it was with these changes, but the unit tests are failing, I've already re-ran they 3 times but no luck. can you check before merging?

Yep. Fixed the test and added a new one covering this scenario (closed agent after a write fails)

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9668735601

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
agent/agent.go 41 43 95.35%
cluster/nats_rpc_server.go 2 4 50.0%
service/handler.go 0 5 0.0%
<!-- Total: 44 53 83.02% -->
Totals Coverage Status
Change from base Build 8848487306: 0.2%
Covered Lines: 4875
Relevant Lines: 7864

💛 - Coveralls