Closed renatoaf closed 5 months ago
@renatoaf idk if it was with these changes, but the unit tests are failing, I've already re-ran they 3 times but no luck. can you check before merging?
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
agent/agent.go | 41 | 43 | 95.35% | ||
cluster/nats_rpc_server.go | 2 | 4 | 50.0% | ||
service/handler.go | 0 | 5 | 0.0% | ||
<!-- | Total: | 44 | 53 | 83.02% | --> |
Totals | |
---|---|
Change from base Build 8848487306: | 0.2% |
Covered Lines: | 4875 |
Relevant Lines: | 7864 |
@renatoaf idk if it was with these changes, but the unit tests are failing, I've already re-ran they 3 times but no luck. can you check before merging?
Yep. Fixed the test and added a new one covering this scenario (closed agent after a write fails)
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
agent/agent.go | 41 | 43 | 95.35% | ||
cluster/nats_rpc_server.go | 2 | 4 | 50.0% | ||
service/handler.go | 0 | 5 | 0.0% | ||
<!-- | Total: | 44 | 53 | 83.02% | --> |
Totals | |
---|---|
Change from base Build 8848487306: | 0.2% |
Covered Lines: | 4875 |
Relevant Lines: | 7864 |