search

topgrade-rs / topgrade

Upgrade all the things
GNU General Public License v3.0
2.06k stars 140 forks source link

Rustup warning, the following packages contain code that will be rejected by a future version of Rust #204

Closed CryoTheRenegade closed 1 year ago

CryoTheRenegade commented 1 year ago

Full Message

Finished release [optimized] target(s) in 2m 40s
warning: the following packages contain code that will be rejected by a future version of Rust: ntapi v0.3.7
note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1`

so yeah, we may want to update dependencies.

9999years commented 1 year ago

How do you get this message? On the dev branch I get this:

$ git rev-parse HEAD
7649b74a8d1e52be17253bb3e35683f375c13f87

$ cargo report future-incompatibilities
error: no reports are currently available
CryoTheRenegade commented 1 year ago

Ok, i found the problem, tokio 1.8 includes mio which depends on ntapi@0.3.7, which will be rejected by cargo eventually. A possible solution is to update our tokio to a version made after November 2021, when mio was last updated. This only affects targets that use x86_64-pc-windows-msvc, as mio isn't targeted to x86_64-pc-windows-gcc. @DottoDev is this acceptable for updating the tokio dep?

s34m commented 1 year ago

Every dependency update with a reason makes sense so good for me.

CryoTheRenegade commented 1 year ago

Tested on dev branch, and no errors to be seen. Thanks yall for your hard work!