topgrade-rs / topgrade

Upgrade all the things
GNU General Public License v3.0
1.95k stars 127 forks source link

GitHub CLI Extensions: wt.exe "The file cannot be accessed by the system." #801

Open worldofgeese opened 4 months ago

worldofgeese commented 4 months ago

Erroneous Behavior

Running topgrade I receive the non-blocking error:

── 11:23:27 - GitHub CLI Extensions ────────────────────────────────────────────
[copilot]: already up to date
✓ Successfully upgraded extensions
ERROR Error looking for C:\Users\dkTaoHan\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Startup\..\..\..\..\..\..\Local\Microsoft\WindowsApps\wt.exe: The file cannot be accessed by the system. (os error 1920)

Expected Behavior

GitHub CLI extensions should be upgraded without sending errors that don't block their update.

Steps to reproduce

  1. Use Windows 11
  2. Install topgrade
  3. Install gh
  4. Install GitHub Copilot CLI: gh extension install github/gh-copilot
  5. Run topgrade

Problem persists without calling from topgrade

Did you run topgrade through Remote Execution

Additional Details

Verbose Output (topgrade -v)

DEBUG Configuration at C:\Users\dkTaoHan\AppData\Roaming\topgrade.toml
DEBUG Loaded configuration: ConfigFile { include: Some(Include { paths: None }), misc: Some(Misc { pre_sudo: None, sudo_command: None, disable: None, ignore_failures: None, remote_topgrades: None, remote_topgrade_path: None, ssh_arguments: None, tmux_arguments: None, set_title: None, display_time: None, assume_yes: None, no_retry: None, run_in_tmux: None, cleanup: None, notify_each_step: None, skip_notify: None, bashit_branch: None, only: None, no_self_update: None, log_filters: None }), pre_commands: Some({}), post_commands: Some({}), commands: Some({}), python: Some(Python { enable_pip_review: None, enable_pip_review_local: None, enable_pipupgrade: None, pipupgrade_arguments: None }), composer: Some(Composer { self_update: None }), brew: Some(Brew { greedy_cask: None, autoremove: None }), linux: Some(Linux { yay_arguments: None, aura_aur_arguments: None, aura_pacman_arguments: None, arch_package_manager: None, show_arch_news: None, garuda_update_arguments: None, trizen_arguments: None, pikaur_arguments: None, pamac_arguments: None, dnf_arguments: None, nix_arguments: None, nix_env_arguments: None, apt_arguments: None, enable_tlmgr: None, redhat_distro_sync: None, suse_dup: None, rpm_ostree: None, emerge_sync_flags: None, emerge_update_flags: None, home_manager_arguments: None }), git: Some(Git { max_concurrency: None, arguments: None, repos: None, pull_predefined: None }), containers: Some(Containers { ignored_containers: None }), windows: Some(Windows { accept_all_updates: None, self_rename: None, open_remotes_in_new_terminal: None, enable_winget: Some(true), wsl_update_pre_release: None, wsl_update_use_web_download: None }), npm: Some(NPM { use_sudo: None }), yarn: Some(Yarn { use_sudo: None }), vim: Some(Vim { force_plug_update: None }), firmware: Some(Firmware { upgrade: None }), vagrant: Some(Vagrant { directories: None, power_on: None, always_suspend: None }), flatpak: Some(Flatpak { use_sudo: None }), distrobox: Some(Distrobox { use_root: None, containers: None }) }
DEBUG Version: 14.0.1
DEBUG OS: x86_64-pc-windows-msvc
DEBUG Args { inner: ["C:\\Users\\dkTaoHan\\AppData\\Local\\Microsoft\\WinGet\\Packages\\topgrade-rs.topgrade_Microsoft.Winget.Source_8wekyb3d8bbwe\\topgrade.exe", "--only", "github_cli_extensions", "-v"] }
DEBUG Binary path: Ok("C:\\Users\\dkTaoHan\\AppData\\Local\\Microsoft\\WinGet\\Packages\\topgrade-rs.topgrade_Microsoft.Winget.Source_8wekyb3d8bbwe\\topgrade.exe")
DEBUG self-update Feature Enabled: true
DEBUG Configuration: Config { opt: CommandLineArgs { edit_config: false, show_config_reference: false, run_in_tmux: false, cleanup: false, dry_run: false, no_retry: false, disable: [], only: [GithubCliExtensions], custom_commands: [], env: [], verbose: true, keep_at_end: false, skip_notify: false, yes: None, disable_predefined_git_repos: false, config: None, remote_host_limit: None, show_skipped: false, log_filter: "warn", gen_completion: None, gen_manpage: false, no_self_update: false }, config_file: ConfigFile { include: Some(Include { paths: None }), misc: Some(Misc { pre_sudo: None, sudo_command: None, disable: None, ignore_failures: None, remote_topgrades: None, remote_topgrade_path: None, ssh_arguments: None, tmux_arguments: None, set_title: None, display_time: None, assume_yes: None, no_retry: None, run_in_tmux: None, cleanup: None, notify_each_step: None, skip_notify: None, bashit_branch: None, only: None, no_self_update: None, log_filters: None }), pre_commands: Some({}), post_commands: Some({}), commands: Some({}), python: Some(Python { enable_pip_review: None, enable_pip_review_local: None, enable_pipupgrade: None, pipupgrade_arguments: None }), composer: Some(Composer { self_update: None }), brew: Some(Brew { greedy_cask: None, autoremove: None }), linux: Some(Linux { yay_arguments: None, aura_aur_arguments: None, aura_pacman_arguments: None, arch_package_manager: None, show_arch_news: None, garuda_update_arguments: None, trizen_arguments: None, pikaur_arguments: None, pamac_arguments: None, dnf_arguments: None, nix_arguments: None, nix_env_arguments: None, apt_arguments: None, enable_tlmgr: None, redhat_distro_sync: None, suse_dup: None, rpm_ostree: None, emerge_sync_flags: None, emerge_update_flags: None, home_manager_arguments: None }), git: Some(Git { max_concurrency: None, arguments: None, repos: None, pull_predefined: None }), containers: Some(Containers { ignored_containers: None }), windows: Some(Windows { accept_all_updates: None, self_rename: None, open_remotes_in_new_terminal: None, enable_winget: Some(true), wsl_update_pre_release: None, wsl_update_use_web_download: None }), npm: Some(NPM { use_sudo: None }), yarn: Some(Yarn { use_sudo: None }), vim: Some(Vim { force_plug_update: None }), firmware: Some(Firmware { upgrade: None }), vagrant: Some(Vagrant { directories: None, power_on: None, always_suspend: None }), flatpak: Some(Flatpak { use_sudo: None }), distrobox: Some(Distrobox { use_root: None, containers: None }) }, allowed_steps: [GithubCliExtensions] }
DEBUG Detected "C:\\Users\\dkTaoHan\\scoop\\shims\\git.EXE" as "git"
DEBUG Detected "C:\\Program Files\\PowerShell\\7\\pwsh.EXE" as "pwsh"
DEBUG Executing command `C:\Program Files\PowerShell\7\pwsh.EXE -NoProfile -Command 'Split-Path $profile'`
DEBUG Path "C:\\Users\\dkTaoHan\\Documents\\PowerShell" exists
DEBUG Path "C:\\Users\\dkTaoHan\\AppData\\Roaming\\.emacs.d" doesn't exist
DEBUG Cannot find "doas"
DEBUG Cannot find "sudo"
DEBUG Cannot find "gsudo"
DEBUG Cannot find "pkexec"
DEBUG Cannot find "please"
DEBUG Step "GitHub CLI Extensions"
DEBUG Detected "C:\\Users\\dkTaoHan\\scoop\\shims\\gh.EXE" as "gh"
DEBUG Executing command `C:\Users\dkTaoHan\scoop\shims\gh.EXE extensions list`

── 11:31:34 - GitHub CLI Extensions ────────────────────────────────────────────
DEBUG Executing command `C:\Users\dkTaoHan\scoop\shims\gh.EXE extension upgrade --all`
[copilot]: already up to date
✓ Successfully upgraded extensions
DEBUG C:\Users\dkTaoHan\.ideavimrc does not exist
DEBUG C:\Users\dkTaoHan\.intellimacs does not exist
DEBUG Checking if \\?\C:\Users\dkTaoHan\AppData\Local\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\LocalState is a git repository
DEBUG Transformed path to C:\Users\dkTaoHan\AppData\Local\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\LocalState
DEBUG Executing command `C:\Users\dkTaoHan\scoop\shims\git.EXE rev-parse --show-toplevel`
DEBUG Command failed: Err(
   0: Command failed: `C:\Users\dkTaoHan\scoop\shims\git.EXE rev-parse --show-toplevel`

      Stderr:
      fatal: not a git repository (or any of the parent directories): .git
   1: `C:\Users\dkTaoHan\scoop\shims\git.EXE` failed: exit code: 128

Location:
   src\steps\git.rs:170)
DEBUG Startup link: Lnk { path: Some("C:\\Users\\dkTaoHan\\AppData\\Roaming\\Microsoft\\Windows\\Start Menu\\Programs\\Startup\\Outlook.lnk"), header: ShellLinkHeader { header_size: 76, link_clsid: 93045959704944114645041356371858166785, link_flags: HAS_LINK_TARGET_ID_LIST | HAS_LINK_INFO | HAS_RELATIVE_PATH | HAS_WORKING_DIR | IS_UNICODE | ENABLE_TARGET_METADATA, file_attributes: (empty), creation_time: 133588131097441682, access_time: 133588131097441682, write_time: 133588131097441682, file_size: 0, icon_index: 0, show_command: SW_SHOWNORMAL, hot_key: HotKeyFlags { low_byte: 0, high_byte: 0 }, reserved1: 0, reserved2: 0, reserved3: 0, created_on: Some(2024-04-28T21:25:09.744Z), modified_on: Some(2024-04-28T21:25:09.744Z), accessed_on: Some(2024-04-28T21:25:09.744Z) }, string_data: StringData { name_string: None, relative_path: Some(".\\olk.exe"), working_dir: Some("C:\\Users\\dkTaoHan\\AppData\\Local\\Microsoft\\WindowsApps\\Microsoft.OutlookForWindows_8wekyb3d8bbwe"), command_line_arguments: None, icon_location: None }, link_target_id_list: LinkTargetIdList, link_info: LinkInfo { link_info_size: 152, link_info_header_size: 28, link_info_flags: Some(VOLUME_ID_AND_LOCAL_BASE_PATH), volume_id_offset: 28, local_base_path_offset: 47, common_network_relative_link_offset: 0, common_path_suffix_offset: 151, local_base_path_offset_unicode: 19, common_path_suffix_offset_unicode: 3, volume_id: None, local_base_path: Some("C:\\Users\\dkTaoHan\\AppData\\Local\\Microsoft\\WindowsApps\\Microsoft.OutlookForWindows_8wekyb3d8bbwe\\olk.exe"), common_network_relative_link: None, common_path_suffix: None, local_base_path_unicode: None, common_path_suffix_unicode: None }, extra_data: ExtraData { darwin_props: None, special_folder_props: Some(SpecialFolderDataBlock { block_size: 16, block_signature: 2684354565, special_folder_id: 40, offset: 255 }), console_props: None, console_fe_props: None, environment_props: None, icon_environment_props: None, known_folder_props: Some(KnownFolderDataBlock { block_size: 28, block_signature: 2684354571, known_folder_id: 153451642297143189807765465356919670159, offset: 255 }), property_store_props: Some(PropertyStoreDataBlock { block_size: 222, block_signature: 2684354569, property_store: [153, 0, 0, 0, 49, 83, 80, 83, 226, 138, 88, 70, 188, 76, 56, 67, 187, 252, 19, 147, 38, 152, 109, 206, 125, 0, 0, 0, 4, 0, 0, 0, 0, 31, 0, 0, 0, 53, 0, 0, 0, 83, 0, 45, 0, 49, 0, 45, 0, 49, 0, 50, 0, 45, 0, 49, 0, 45, 0, 51, 0, 51, 0, 50, 0, 52, 0, 52, 0, 48, 0, 52, 0, 54, 0, 49, 0, 57, 0, 45, 0, 49, 0, 49, 0, 48, 0, 56, 0, 48, 0, 57, 0, 53, 0, 48, 0, 50, 0, 51, 0, 45, 0, 50, 0, 52, 0, 55, 0, 53, 0, 57, 0, 51, 0, 54, 0, 49, 0, 56, 0, 52, 0, 45, 0, 51, 0, 56, 0, 57, 0, 57, 0, 48, 0, 48, 0, 54, 0, 49, 0, 50, 0, 57, 0, 0, 0, 0, 0, 0, 0, 0, 0, 57, 0, 0, 0, 49, 83, 80, 83, 177, 22, 109, 68, 173, 141, 112, 72, 167, 72, 64, 46, 164, 61, 120, 140, 29, 0, 0, 0, 104, 0, 0, 0, 0, 72, 0, 0, 0, 53, 49, 11, 157, 11, 227, 69, 76, 189, 226, 14, 156, 57, 38, 130, 253, 0, 0, 0, 0, 0, 0, 0, 0] }), shim_props: None, tracker_props: Some(TrackerDataBlock { block_size: 96, block_signature: 2684354563, length: 88, version: 0, machine_id: 962847765621941742945, droid: [282952718541911288902569159277242802662, 243598432465991496336807886616959156697], droid_birth: [282952718541911288902569159277242802662, 243598432465991496336807886616959156697] }), vista_and_above_idlist_props: None } }
DEBUG C:\Users\dkTaoHan\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Startup\.\olk.exe does not exist
DEBUG Startup link: Lnk { path: Some("C:\\Users\\dkTaoHan\\AppData\\Roaming\\Microsoft\\Windows\\Start Menu\\Programs\\Startup\\Terminal Quake.lnk"), header: ShellLinkHeader { header_size: 76, link_clsid: 93045959704944114645041356371858166785, link_flags: HAS_LINK_TARGET_ID_LIST | HAS_LINK_INFO | HAS_RELATIVE_PATH | HAS_WORKING_DIR | HAS_ARGUMENTS | IS_UNICODE | ENABLE_TARGET_METADATA, file_attributes: (empty), creation_time: 133588053184787924, access_time: 133588060538828445, write_time: 133588060538828445, file_size: 0, icon_index: 0, show_command: SW_SHOWNORMAL, hot_key: HotKeyFlags { low_byte: 0, high_byte: 0 }, reserved1: 0, reserved2: 0, reserved3: 0, created_on: Some(2024-04-28T19:15:18.478Z), modified_on: Some(2024-04-28T19:27:33.882Z), accessed_on: Some(2024-04-28T19:27:33.882Z) }, string_data: StringData { name_string: None, relative_path: Some("..\\..\\..\\..\\..\\..\\Local\\Microsoft\\WindowsApps\\wt.exe"), working_dir: Some("C:\\Users\\dkTaoHan\\AppData\\Local\\Microsoft\\WindowsApps"), command_line_arguments: Some("-w _quake"), icon_location: None }, link_target_id_list: LinkTargetIdList, link_info: LinkInfo { link_info_size: 109, link_info_header_size: 28, link_info_flags: Some(VOLUME_ID_AND_LOCAL_BASE_PATH), volume_id_offset: 28, local_base_path_offset: 47, common_network_relative_link_offset: 0, common_path_suffix_offset: 108, local_base_path_offset_unicode: 19, common_path_suffix_offset_unicode: 3, volume_id: None, local_base_path: Some("C:\\Users\\dkTaoHan\\AppData\\Local\\Microsoft\\WindowsApps\\wt.exe"), common_network_relative_link: None, common_path_suffix: None, local_base_path_unicode: None, common_path_suffix_unicode: None }, extra_data: ExtraData { darwin_props: None, special_folder_props: Some(SpecialFolderDataBlock { block_size: 16, block_signature: 2684354565, special_folder_id: 4294967295, offset: 58 }), console_props: None, console_fe_props: None, environment_props: None, icon_environment_props: None, known_folder_props: Some(KnownFolderDataBlock { block_size: 28, block_signature: 2684354571, known_folder_id: 191320649484052062574313519749765402492, offset: 58 }), property_store_props: Some(PropertyStoreDataBlock { block_size: 222, block_signature: 2684354569, property_store: [153, 0, 0, 0, 49, 83, 80, 83, 226, 138, 88, 70, 188, 76, 56, 67, 187, 252, 19, 147, 38, 152, 109, 206, 125, 0, 0, 0, 4, 0, 0, 0, 0, 31, 0, 0, 0, 53, 0, 0, 0, 83, 0, 45, 0, 49, 0, 45, 0, 49, 0, 50, 0, 45, 0, 49, 0, 45, 0, 51, 0, 51, 0, 50, 0, 52, 0, 52, 0, 48, 0, 52, 0, 54, 0, 49, 0, 57, 0, 45, 0, 49, 0, 49, 0, 48, 0, 56, 0, 48, 0, 57, 0, 53, 0, 48, 0, 50, 0, 51, 0, 45, 0, 50, 0, 52, 0, 55, 0, 53, 0, 57, 0, 51, 0, 54, 0, 49, 0, 56, 0, 52, 0, 45, 0, 51, 0, 56, 0, 57, 0, 57, 0, 48, 0, 48, 0, 54, 0, 49, 0, 50, 0, 57, 0, 0, 0, 0, 0, 0, 0, 0, 0, 57, 0, 0, 0, 49, 83, 80, 83, 177, 22, 109, 68, 173, 141, 112, 72, 167, 72, 64, 46, 164, 61, 120, 140, 29, 0, 0, 0, 104, 0, 0, 0, 0, 72, 0, 0, 0, 53, 49, 11, 157, 11, 227, 69, 76, 189, 226, 14, 156, 57, 38, 130, 253, 0, 0, 0, 0, 0, 0, 0, 0] }), shim_props: None, tracker_props: Some(TrackerDataBlock { block_size: 96, block_signature: 2684354563, length: 88, version: 0, machine_id: 962847765621941742945, droid: [282952718541911288902569159277242802662, 243598432465991486892074919592158730387], droid_birth: [282952718541911288902569159277242802662, 243598432465991486892074919592158730387] }), vista_and_above_idlist_props: None } }
ERROR Error looking for C:\Users\dkTaoHan\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Startup\..\..\..\..\..\..\Local\Microsoft\WindowsApps\wt.exe: The file cannot be accessed by the system. (os error 1920)
DEBUG Checking if \\?\C:\Users\dkTaoHan\Documents\PowerShell is a git repository
DEBUG Transformed path to C:\Users\dkTaoHan\Documents\PowerShell
DEBUG Executing command `C:\Users\dkTaoHan\scoop\shims\git.EXE rev-parse --show-toplevel`
DEBUG Command failed: Err(
   0: Command failed: `C:\Users\dkTaoHan\scoop\shims\git.EXE rev-parse --show-toplevel`

      Stderr:
      fatal: not a git repository (or any of the parent directories): .git
   1: `C:\Users\dkTaoHan\scoop\shims\git.EXE` failed: exit code: 128

Location:
   src\steps\git.rs:170)

── 11:31:35 - Summary ──────────────────────────────────────────────────────────
GitHub CLI Extensions: OK
DEBUG Desktop notification: Topgrade finished successfully
SteveLauC commented 4 months ago

Problem persists without calling from topgrade

Yes

If you can reproduce this with $ gh extension upgrade --all, then I kinda guess this is not an issue of Topgrade, but an issue of the GitHub CLI tool?

worldofgeese commented 4 months ago

Problem persists without calling from topgrade Yes

If you can reproduce this with $ gh extension upgrade --all, then I kinda guess this is not an issue of Topgrade, but an issue of the GitHub CLI tool?

Whoops, sorry, that was a mistake on my part. I intended to check the "No" box. I have updated my original issue now.