topgrade-rs / topgrade

Upgrade all the things
GNU General Public License v3.0
1.7k stars 113 forks source link

Helix name clash with hexdump alternative #848

Open lucaspar opened 2 days ago

lucaspar commented 2 days ago

Erroneous Behavior

Topgrade attempts to upgrade "Helix" upon finding a hx binary, which clashes with cargo's hx binary (alt to hexdump).

Expected Behavior

The existence of an hx binary shouldn't trigger a helix upgrade on its own.

Steps to reproduce

Have hx installed, but not the Helix text editor.

cargo install hx
topgrade --only helix
# incorrect detection of helix; also happens with `topgrade` alone.

Possible Cause (Optional)

This seems to be the problematic line.

Additional Details

Verbose Output (topgrade -v)

topgrade --only helix

── 12:20:37 - Helix ────────────────────────────────────────────────────────────
error: unexpected argument '--grammar' found

  tip: to pass '--grammar' as a value, use '-- --grammar'

Usage: hx [OPTIONS] [INPUTFILE]

For more information, try '--help'.

── 12:20:37 - Summary ──────────────────────────────────────────────────────────
helix: FAILED
lucaspar commented 2 days ago

Related PR: #710

@SteveLauC