search

topgrade-rs / topgrade

Upgrade all the things
GNU General Public License v3.0
1.95k stars 127 forks source link

Doom Emacs added AOT compile support #884

Open raszi opened 1 month ago

raszi commented 1 month ago

I want to suggest a new option

To enable the AOT compilation option for the doom upgrade command.

More information

@hlissner added AOT compilation option for the sync and upgrade commands. It would be great if Topgrade would support that.

https://github.com/doomemacs/doomemacs/commit/e3fdfee1c54b10d84c4cd87dab6c9eb8beab87e3

SteveLauC commented 2 weeks ago

Hi, sorry for the late reply.

In the commit message:

(This is a stop-gap solution until the v3.0 release)

Does the sentence mean that this AOT feature is a workaround and will be replaced by something else in version 3.0?

hlissner commented 2 weeks ago

Does the sentence mean that this AOT feature is a workaround and will be replaced by something else in version 3.0?

I meant that the implementation will change, but the --aot option is a permanent fixture of doom sync and doom upgrade going forward.

SteveLauC commented 2 weeks ago

I meant that the implementation will change, but the --aot option is a permanent fixture of doom sync and doom upgrade going forward.

Get it, thanks for the explanation, let's impl this feature in Topgrade!

Should we add this option by default or make it optional and configurable 🤔