search

tophat / codewatch

[deprecated] Monitor and manage deeply customizable metrics about your python code using ASTs
https://codewatch.io
Apache License 2.0
38 stars 3 forks source link

Fixes #78 - return an appropriate exit code if there were errors in the assertion functions #80

Closed vardan10 closed 5 years ago

vardan10 commented 5 years ago

For #78 - Now returning -1 if failures or errors.

lime-green commented 5 years ago

@vardan10 Thanks for you contribution Vardan! I'll see if I can get the tests running for forks (probably early tomorrow) and then I can merge this.

lime-green commented 5 years ago

@vardan10 the CI should run now for your fork. Could you add a test for this? Add a new config_module in this directory: https://github.com/tophat/codewatch/tree/master/tests/config_modules with a single assertion that raises an exception, then call it from within test_bin.py and assert code is 255

codecov[bot] commented 5 years ago

Codecov Report

Merging #80 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #80   +/-   ##
======================================
  Coverage    96.4%   96.4%           
======================================
  Files           8       8           
  Lines         334     334           
  Branches       46      46           
======================================
  Hits          322     322           
  Misses          6       6           
  Partials        6       6
Flag Coverage Δ
#py27 96.4% <ø> (ø) :arrow_up:
#py36 96.4% <ø> (ø) :arrow_up:
#py37 96.4% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9b3b67c...e88f053. Read the comment docs.

vardan10 commented 5 years ago

@lime-green I have added a unit test. Please Check

vardan10 commented 5 years ago

@lime-green -- Did all the changes