tophat / jenkins-timeline-plugin

A build timeline to facilitate the inspection of Jenkins pipelines and identify bottlenecks.
https://jenkinstimeline.com
Apache License 2.0
34 stars 11 forks source link

#116/feat build navigation button #120

Closed KimiJL closed 3 years ago

KimiJL commented 3 years ago

Demo

https://user-images.githubusercontent.com/25181701/110224560-b91a9800-7eaa-11eb-9cac-2a28d26423bc.mp4

Description

resolves #116 Issue

Adding a simple previous and next build button to quickly navigate between builds of the same pipeline.

Note: this isn't aware of the max build number, so if you click on "next build" on the most recent build, it'd take you to a blank page.

DevQA

:white_check_mark: created a pipeline with 3 builds, see that on first build, "previous build" button isn't rendered, and is able to navigate to the next build.

:white_check_mark: from build 2, able to go back to first build, or to next build.

:white_check_mark: From build 3, see that next build button is not rendered because it's the last build in the job.

DevQA Prep

DevQA Steps

Comments:

mcataford commented 3 years ago

It goes without saying, thanks for contributing :rocket: This is awesome. :)

KimiJL commented 3 years ago

Left a couple of thoughts.

You can, in principle, get the total number of runs of a jobs via the higher-level job describe API that the Jenkins pipeline exposes. This way, you could know about the upper bound of possible build IDs.

From a design perspective, it would be nice to have the navigation be part of the topmost header row instead of adding height to the header. I'd love to eventually pare down the UI a bit to avoid taking valuable real estate away from the timeline visual itself.

The new attached video reflects these changes.

mcataford commented 3 years ago

@all-contributors please add @KimiJL for code

allcontributors[bot] commented 3 years ago

@mcataford

I've put up a pull request to add @KimiJL! :tada: