tophat / jenkins-timeline-plugin

A build timeline to facilitate the inspection of Jenkins pipelines and identify bottlenecks.
https://jenkinstimeline.com
Apache License 2.0
34 stars 11 forks source link

Include webapp build in maven build #58

Closed mcataford closed 5 years ago

mcataford commented 5 years ago

Description

DevQA

DevQA Prep

Set up a clean environment using the maven:3.3-jdk-8 Docker image. Install git and pull down the repo. This way, you can ensure that the build isn't affected by globally-installed packages or any kind. Additionally, this replicates what happens in CI.

DevQA Steps

Comments:

mcataford commented 5 years ago

This partially addresses #56, some more cleanup is possible, but it's a start.

mcataford commented 5 years ago

As of https://github.com/tophat/jenkins-timeline-plugin/pull/58/commits/dc2e704f0491255ef2f0b0c6e46383c02396c3e3, building using mvn install has the entire build process working fine, current issue is stage duplication.

TODO:

mcataford commented 5 years ago

🚀

mcataford commented 5 years ago

Ready for self-QA and CR/QA as of https://github.com/tophat/jenkins-timeline-plugin/pull/58/commits/a61c7ad5c6684d779c27197bc47c5686fb5d6c87. hpi seems viable.

mcataford commented 5 years ago

Passes self-QA, adjusted version number.