Closed mcataford closed 5 years ago
This partially addresses #56, some more cleanup is possible, but it's a start.
As of https://github.com/tophat/jenkins-timeline-plugin/pull/58/commits/dc2e704f0491255ef2f0b0c6e46383c02396c3e3, building using mvn install
has the entire build process working fine, current issue is stage duplication.
TODO:
npm
command to build to plugin force copies to overwrite, or cleans the target before copying.🚀
Ready for self-QA and CR/QA as of https://github.com/tophat/jenkins-timeline-plugin/pull/58/commits/a61c7ad5c6684d779c27197bc47c5686fb5d6c87. hpi
seems viable.
Passes self-QA, adjusted version number.
Description
pom.xml
npm
build calls inside the Maven build process to be able to build everything only usingmvn install
.Makefile
to remove redundant recipebuild_all
sincebuild
is all that is needed to build the plugin now.build_all
deprecation (usesbuild
).DevQA
DevQA Prep
Set up a clean environment using the
maven:3.3-jdk-8
Docker image. Installgit
and pull down the repo. This way, you can ensure that the build isn't affected by globally-installed packages or any kind. Additionally, this replicates what happens in CI.DevQA Steps
mvn install
ormvn clean install
;npm
is installed during the build process and that the webapp is built in thecompile
phase.hpi
artifact is viable (although observing thatsrc/main/webapp
is well-formed and that the build tests pass is sufficient to affirm confidently that thehpi
is viable).Comments:
execution
blocks. This can be addresses later on.maven-surefire
using the system classloader and failing on tests.make build
was also bypassed entirely.