search

tophat / syrupy

:pancakes: The sweeter pytest snapshot plugin
https://tophat.github.io/syrupy
Apache License 2.0
501 stars 33 forks source link

fix: preserve Falsy values in assertion diff function #789

Closed atharva-2001 closed 11 months ago

atharva-2001 commented 11 months ago

Description

This PR does a None check here-https://github.com/tophat/syrupy/blob/f4bc8453466af2cfa75cdda1d50d67bc8c4396c3/src/syrupy/assertion.py#L209

This helps me extend the SingleFileSnapshotExtension to save snapshots as HDF files. Please see issue https://github.com/tophat/syrupy/issues/786 to know more.

Related Issues

Closes https://github.com/tophat/syrupy/issues/786

Checklist

Additional Comments

No additional comments.

noahnu commented 11 months ago

@all-contributors add @atharva-2001 for code

allcontributors[bot] commented 11 months ago

@noahnu

I've put up a pull request to add @atharva-2001! :tada:

tophat-opensource-bot commented 11 months ago

:tada: This PR is included in version 4.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

atharva-2001 commented 11 months ago

Thank you!!