topi314 / LavaSrc

A collection of additional Lavaplayer/Lavalink Sources
Apache License 2.0
161 stars 51 forks source link

Mp3 frame not found from yandex music track #193

Closed Krispeckt closed 4 months ago

Krispeckt commented 4 months ago

Checked on different tokens, sometimes it throws the error Mp3 frame not found. In addition, I checked on other sources everything works correctly. The error is not tied to a specific track

Lavalink log lavalink.log

llimonix commented 4 months ago

I noticed that the tracks work in the application and so on, if they were saved, but when clicking on the track link, Yandex gives an error

I think the problem is still on the Yandex Music side.

Krispeckt commented 4 months ago

I noticed that the tracks work in the application and so on, if they were saved, but when clicking on the track link, Yandex gives an error

I think the problem is still on the Yandex Music side.

I don't know, but if you follow the link to the mp3 track is there and it plays. I started noticing the error a week ago, but rarely. I'm also inclined to the option that this problem will probably resolve itself in time.

Krispeckt commented 4 months ago

Now checked yandex music from lavaplayer and it works correctly compared to the plugin. So, there is a suggestion to just take it and implement it in the plugin :>

llimonix commented 4 months ago

Now checked yandex music from lavaplayer and it works correctly compared to the plugin. So, there is a suggestion to just take it and implement it in the plugin :>

I would like at least a temporary fix. Since after a couple dozen errors, the bot goes silent

Krispeckt commented 4 months ago

Now checked yandex music from lavaplayer and it works correctly compared to the plugin. So, there is a suggestion to just take it and implement it in the plugin :>

I would like at least a temporary fix. Since after a couple dozen errors, the bot goes silent

I don't know, but I implemented Yandex music in my plugin and I do what I want with it)) At the moment I am satisfied with the work of Yandex music from lavaplayer, but I had to mess with it

topi314 commented 4 months ago

from what I can tell comparing both there should be no difference in this tho

Krispeckt commented 4 months ago

from what I can tell comparing both there should be no difference in this tho

I also compared, but for some reason Yandex music from lavaplayer works correctly, but from LavaSrc throws errors Mp3 frame not found :/

topi314 commented 4 months ago

feel free to keep testing, but I would expect both to fail at some point, keep us posted

Krispeckt commented 4 months ago

lul, I fixed it :0

Krispeckt commented 4 months ago

image

Really why doesn't it work :/

Krispeckt commented 4 months ago

This problem solved?

https://github.com/topi314/LavaSrc/pull/196

Krispeckt commented 4 months ago

Problem solved, tested for about 2 hours, not a single error when starting track playback.

Pr with fix #196

topi314 commented 4 months ago

this will be included in the next release

topi314 commented 4 months ago

published in https://github.com/topi314/LavaSrc/releases/tag/4.1.1