topi314 / SponsorBlock-Plugin

Lavalink SponsorBlock Plugin
Apache License 2.0
21 stars 2 forks source link

Feature Request: Pre-defined segments to skip (config file). #5

Closed Rajdave69 closed 1 year ago

Rajdave69 commented 1 year ago

So basically, instead of using the current method to tell the plugin which segment to skip every video in play, would it be possible to have a config file in which segments to skip can be pre-defined for every video.

This will be useful particularly for people using libraries which communicate with Lavalink, like wavelink for Python. There is no way to use a plugin like this with the lib.

Using a config at all could be configurable too. Like an option which disables the config system and uses the thing you do directly in play (default?).

topi314 commented 1 year ago

while this wouldnt be hard to implement having a static list for every server sounds kinda annoying. Some people might want it disabled or enabled or with other segment categories. The feature would be rather poor implemented then imo

Rajdave69 commented 1 year ago

having a static list for every server sounds kinda annoying.

Well, the config system would be only way one of skipping segments, and the secondary method (the play method overrides it). And the whole config system could be disabled by default, and the config doesn't do anything unless the person enables it specifically

Some people might want it disabled or enabled or with other segment categories.

Yep! Don't remove the current play way of using the plugin through play.

The feature would be rather poor implemented then imo

I mean, This is the only thing I could think of for the people who use libraries for lavalink and can't change what the lib sends in play.

topi314 commented 1 year ago

A better way would be to implement a feature to send arbitrary data to lavalink which would be needed to support other plugins too

Rajdave69 commented 1 year ago

Hmm, fair enough. I'll try to get that done. Do I close this issue?