search

topjohnwu / Magisk

The Magic Mask for Android
GNU General Public License v3.0
47.6k stars 12.08k forks source link

MagiskHide stops working with an extensive list of Apps to hide root from #1138

Closed NoobAndProud closed 5 years ago

NoobAndProud commented 5 years ago

It needs more testing but I noticed that MagiskHide is fine after a reboot but stops working after an inconsistent (1-5 hours) amount of time. Talking about above 50+ apps (games, Google apps, "apps who doesn't use root as such don't need to see root"). Getting an even bigger list (100+) does force MagiskHide to completely fail (even after reboot). If logs are necessary to define further work I'm happy to oblige but need instructions to do so. I'm sorry for any confusion in my error report as English isn't my native language. I don't expect that MagiskHide can work with an infinite amount of apps and failing directly is (in my opinion) a better way to handle it but this error report is more about that it's failing after a inconsistent time period (thinking you are safe and then apps fail and block your device).

DenyDarko commented 5 years ago

John already mentioned multiple times that this is expected when you spam the hide list the way Magisk currently works. You only add the absolutely required stuff to the hide list.

Didgeridoohan commented 5 years ago

Apart from what's already been said, what Magisk version are you testing this on? Besides the fact that you should always report bugs based on the current code (so only in the latest Canary release), if you happen to be using Magisk v18.0 or v18.1, MagiskHide intermittingly failing is a known bug on those releases that has been fixed upstream.

NoobAndProud commented 5 years ago

I was not aware but I thank you for the feature request on #1139. I had noticed that MagiskHide completely stops working at reboot with a to big list, but with a "moderately" long list it stopped working after running for a longer period that was what threw me off.

NoobAndProud commented 5 years ago

@digeridoohan Newest OOS update 9.0.12, 7.0.0 Manager, 18.1 Magisk Stable.

Didgeridoohan commented 5 years ago

So, in other words: you can close this issue, since it's already been fixed. But that doesn't mean that you should keep a Hide list that large on future releases...