search

topjohnwu / Magisk

The Magic Mask for Android
GNU General Public License v3.0
47.59k stars 12.08k forks source link

Magisk Hide not working #1142

Closed kotori2 closed 5 years ago

kotori2 commented 5 years ago

Reproduce:

  1. Revoke su permission to Terminal
  2. Add Terminal in Magisk Hide
  3. Execute /sbin/su or which su, it can detect su binary. photo_2019-02-27_21-18-21 photo_2019-02-27_21-18-22 Version: Magisk v18.1, Magisk Manager v7.0.0 Device: Oneplus 6, Oxygen OS, Jan security patch. After upgrade to v7.0 & v18.0, there are lots of weird bugs, idk whether it can be reproduce on other device because this is the only Android device I have.
huyz-git commented 5 years ago

这是一个API 22的应用，你是不是拒绝了它的存储权限？ 想让magiskhide工作：对于API 23及以上的应用，运行时的存储权限可以禁，但不能用appops忽略其存储op。对于API 22及以下的应用，不能禁存储权限，也不能用appops忽略其存储op。 具体原因是如果用appops忽略了应用的存储op，那么它的进程的挂载命名空间不会与zygote分离，导致magisk没法对它隐藏。 As this app is at API 22, did you disable its storage permission? To make magiskhide works: For app with API 23 or higher, its runtime storage permission can be disabled. But its storage op can't be ignored by appops. For app with API 22 or lower, its storage permission can't be disabled. And its storage op can't be ignored by appops. The reason for that is if an app's storage op is ignored by appops, then the mount namespace of its process will not be separated from zygote, which means that magisk can't be hidden to it.

kotori2 commented 5 years ago

@huyizheng 刚才试了下把存储空间权限打开，但是不管用。

Didgeridoohan commented 5 years ago

Only report bugs based on the current code... Magisk v18.0 and v18.1 have bug concerning MagiskHide that has been fixed upstream.

Unless you can reproduce the issue on the current Canary build, please close the issue since it's not relevant to the current code.