topjohnwu / Magisk

The Magic Mask for Android
GNU General Public License v3.0
48.09k stars 12.24k forks source link

Recent MagiskManager Canary release crashes on launch #1155

Closed DenyDarko closed 5 years ago

DenyDarko commented 5 years ago

EDIT: CHECK FIRST COMMENT.

Hey @topjohnwu

Latest Canary is crashing on launch:

Other users on XDA Canary thread confirm it too.

OnePlus6 on OB13

FATAL EXCEPTION: main Process: com.CPNEH9FSPpGGRP.M, PID: 29119 java.lang.RuntimeException: Unable to start activity ComponentInfo{com.CPNEH9FSPpGGRP.M/a.b}: java.lang.NullPointerException: Attempt to invoke virtual method 'void a.fy.a()' on a null object reference at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3056) at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3191) at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:78) at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:108) at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:68) at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1920) at android.os.Handler.dispatchMessage(Handler.java:106) at android.os.Looper.loop(Looper.java:193) at android.app.ActivityThread.main(ActivityThread.java:6912) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:537) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858) Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'void a.fy.a()' on a null object reference at a.gk.setBackgroundDrawable(Unknown Source:5) at android.view.View.setBackground(View.java:21652) at android.view.View.(View.java:5551) at android.widget.ImageView.(ImageView.java:177) at android.widget.ImageButton.(ImageButton.java:86) at android.widget.ImageButton.(ImageButton.java:82) at a.gk.(Unknown Source:4) at androidx.appcompat.widget.Toolbar.p(Unknown Source:14) at androidx.appcompat.widget.Toolbar.a(Unknown Source:0) at a.jj.(Unknown Source:394) at a.jj.(Unknown Source:1) at a.bn.(Unknown Source:27) at a.aq.a(Unknown Source:37) at a.an.a(Unknown Source:4) at a.bal.onCreate(Unknown Source:46) at android.app.Activity.performCreate(Activity.java:7149) at android.app.Activity.performCreate(Activity.java:7140) at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1288) at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3031) ... 11 more

IdanHo commented 5 years ago

It seems topjohnwu has realised this and updated the magisk canary app with the build error fix, unfortunately, it seemes some people including me and you downloaded the app just at the right time to get the broken version, i fixed it by just downloading the fixed version directly and updating manually. (over at https://raw.githubusercontent.com/topjohnwu/magisk_files/master/canary_builds/app-full-release.apk)

DenyDarko commented 5 years ago

It seems topjohnwu has realised this and updated the magisk canary app with the build error fix, unfortunately, it seemes some people including me and you downloaded the app just at the right time to get the broken version, i fixed it by just downloading the fixed version directly and updating manually. (over at https://raw.githubusercontent.com/topjohnwu/magisk_files/master/canary_builds/app-full-release.apk)

Thanks for the heads-up @IdanHo .

I'm leaving this open for a while so if someone's on the same situation will see your comment :)

martyfender commented 5 years ago

Even with the updated version, MM still crashes for many of us when trying to access the hide list. I posted logs in the Canary thread. The latest unofficial build also crashes, on 3 devices and the 2 devices I have Canary on.

They are all, Nextbook Ares 8A's, x86, Android 6.0.1 tablets.

Thanks