dioni21
commented
5 years ago This happened to me with Magisk 19.1, I had to roll back to 18.1. Did not try 19.2 yet.
Closed callihn closed 5 years ago
dioni21
commented
5 years ago This happened to me with Magisk 19.1, I had to roll back to 18.1. Did not try 19.2 yet.
callihn
commented
5 years ago So obviously these issues are not getting addressed.
How did you rollback, from a backup or by flashing 18.1?
Didgeridoohan
commented
5 years ago Without proper info and details (logs, and not just the Magisk log), there's nothing to address...
callihn
commented
5 years ago What "proper info and details" and what logs?
Didgeridoohan
commented
5 years ago Did you read the instructions before submitting a bug report? https://github.com/topjohnwu/Magisk/blob/master/README.MD#bug-reports
callihn
commented
5 years ago Now you're just grasping at straws with your trolling. You still didn't answer the question I asked you.
Specially I asked you what do you consider to be the "proper info and details" to include and what logs?
dioni21
commented
5 years ago @callihn
How did you rollback, from a backup or by flashing 18.1?
Flashing 18.1
I just flashed 19.2, just to check, and my report is almost the same. Magisk Manager (7.2.0) reports Magisk as not installed, but when I start some app requesting for root, I get the confirmation popup, and can give root permission! Maybe the bug is in Manager, not Magisk.
callihn
commented
5 years ago I tend to agree since we are using the same version of Magisk Manager which I just updated today before updating Magisk and we are getting the same results using different versions of Magisk and I just came from 19.1 without this issue. Though my apps were not getting root at startup anyway.
Didgeridoohan
commented
5 years ago Troll? Ok...
Ever heard of the expression "teach someone to fish, feed 'em for a day", etc?
callihn
commented
5 years ago Exactly my point. You are not teaching anything you are simply walking down the bank saying I'm not fishing right while referring to this mystery "proper info and details" and magical logs and have yet to give any insight on your comment although questioned, so you are just trolling by claiming I am not reporting the issue correctly but you don't seem to know or want to share the correct method you refer to thus you are merely wasting time and space being completely and totally unhelpful and unproductive trying to look important and knowledgeable and thus far I gather that you are neither. You can't even get a simple saying right. It's "Give a man a fish and you feed him for a day; teach a man to fish and you feed him for a lifetime."
That being said, back to the issue at hand....
This appears to be an issue with Magisk 19.2, the issue occured and I uninstalled Magisk Manager 7.2.0 and installed 7.1.2 and it also said Magisk 19.2 was not installed, no apps had root or were able to request root they just hung at the point where they would have normally sent a root request. I've reverted back to Magisk 19.1 and Magisk Manager 7.2.0 and the issue seems to be gone now.
Didgeridoohan
commented
5 years ago Let me quote myself: "proper info and details (logs, and not just the Magisk log)". That reads: proper info and details = logs.
And then I linked you to the documentation for this repository, specially the section on bug reports. Did you open said link? Follow that and you'll get information on what kind of logs are expected.
callihn
commented
5 years ago "These builds are NOT for the faint of heart: professional users and developers only!"
I read better than most, I am neither of those if I were or wanted to be it would be just as easy to fix it for myself and move on. So...
Didgeridoohan
commented
5 years ago I read better than most
I would say that parts of this exchange contradict that statement...
The fact remains that without logs showing what's going on and why you're experiencing this there's very little chance of anything being fixed (except by chance and luck).
callihn
commented
5 years ago Not really.
dioni21
commented
5 years ago Feedback: I just installed Manager Canary Debug, and it is now working. Not sure if it is random yet, let's see for a few days.
callihn
commented
5 years ago Hoping for the best do let us know. I've had very little time on my hands and have had some other issues to deal with like my SD card failing app updates that had to be reversed etc. So I apologize for the short bug report but felt it was at least worth a mention. Thanks for making the effort.
MysteryIII
commented
5 years ago Right now I don't have the time for testing and logging, think I will give them in a few days. Just wanted to give as much feedback as I can right now: Samsung Galaxy S5 Stock ROM (6.0/Marshmallow), Boeffla Kernel 2.5(last)
Updating from Magisk 18.1 to 19.2 isn't possible inside of the Manager 7.2.0. It will give you only the option to download zip and to install selecting tar or img file. If you still select the zip file it will say it's unsupported.
Flashing the zip file in Recovery gives the result that Magisk is shown as "not installed" inside the Manager. However Xposed Modules are still working. (Dirty) Downgrading again resulted in lose of Xposed Modules and still shown as not installed. So I needed to use uninstaller than flash 15.31 (last version that allows installing Xposed for Samsung/Touchwiz 6.0), install Xposed Module and than flash Magisk 18.1 again.
As this phone is my daily driver, and especially (re)generating Dalvik Cache takes about 25 minutes on the phone, I can only sometimes make tests.
callihn
commented
5 years ago I know the feeling. I don't have a phone just to play with either it has to be working every day that's why I run the "STABLE" branch, some people just don't get that apparently. That being said the current Canary build is working without this issue though there where a few install hicups.
callihn
commented
5 years ago Not fixed. Tested with Canary DEBUG. Logs and details included above.
MysteryIII
commented
5 years ago I also need to add, that it's impossible to uninstall the Manager in "hidden" status. Neither the flashable Uninstaller nor the Android Package Manager can do it. And as I lost root, I can't use third party App. However the option to unhide the Manager isn't available as Magisk Manager says there is no Magisk installed. Only Option was to delete it in Recovery, but this is just a workaround for a bug and you still need to know the name of the random package string. There need to be an fallback option, so you can unhide the Manager if there is some problem with Magisk so you are always able to fully wipe Magisk.
Didgeridoohan
commented
5 years ago @MysteryIII That's a new one, that if it's an actual bug probably deserves its own issue.
But, the uninstaller zip can't remove the repackaged app since it doesn't know what the new package name is, so that's perfectly normal. And there should be no issues uninstalling the app even when it's repackaged since it's still just a normal app... On my devices I have no issue uninstalling the hidden Manager. Would be interesting to know more about this.
callihn
commented
5 years ago Impossible to have a plan B for that though. Could probably use Link2SD, Titanium Backup and others to uninstall it I don't know as I don't hide it.
MysteryIII
commented
5 years ago @Didgeridoohan Well, I didn't really expect it to work, but I still tried it. Every try to regular uninstall it took about 10 minutes and ended in a sudden reboot, also wiped caches. So I expected that there is still a "zombie" hide function working. I hadn't Matlog installed so I can't provide a log about all this, sorry. As the overall procedure took more than 2 hours (as I said rebuilding Dalvik/ART Cache takes about 25 minutes), I won't test it during this week, maybe at weekend.
@callihn As I lost root and wasn't able to get it back with the preinstalled Manager App, third party Apps were not possible.
topjohnwu
commented
5 years ago You are using some apps/processes that spams root access.
callihn
commented
5 years ago I'm not running anything new for this version that I haven't been running since Magisk came out and several apps need access at boot so that's nothing new either.
callihn
commented
5 years ago Those UIDs appear to belong to Magisk.
u0_a137@m1:/ # id 10112
uid=0(root) gid=0(root) context=u:r:magisk:s0
u0_a137@m1:/ # id 10339
uid=0(root) gid=0(root) context=u:r:magisk:s0
u0_a137@m1:/ #Latest build seems to have resolved this issue, after a perfect install I wiped cacahe and dalvik cache again, no problems at boot and I'm not getting the error for Magisk Manager not responding either.
Tested with lastest Canary DEBUG for Magisk and Magisk Manager. Magisk not running correctly, mostly random at boot time but this was obtained after wipeing Cache and Dalvik Cache in TWRP and rebooting.
Including both failed log and sucess log.
Failed log, appears to be a failure to run "module service scripts"? See success log and note this difference:
Success log, note lines 411- 415 which do not exist in failed log above:
This is the part that appears to be missing in the failed log: