topjohnwu / Magisk

The Magic Mask for Android
GNU General Public License v3.0
47.6k stars 12.09k forks source link

v19.4: su: cannot find manager when using hide / repack #1797

Closed micw closed 5 years ago

micw commented 5 years ago

Hello,

on 19.4 with hide enabled and repacked manager, I cannot get root via ADB shell. Su gives always "permission denied". Here's the log:

08-27 22:07:14.363   472 16181 D Magisk  : su: request from pid=[16170], client=[11]
08-27 22:07:14.363   472 16181 D Magisk  : su: request from uid=[2000]
08-27 22:07:14.363   472 16181 D Magisk  : magiskdb: query magiskhide=[1]
08-27 22:07:14.363   472 16181 D Magisk  : magiskdb: query root_access=[3]
08-27 22:07:14.364   472 16181 E Magisk  : su: cannot find manager
08-27 22:07:14.364   472 16181 W Magisk  : su: request rejected (2000)

Looks different than #882.

micw commented 5 years ago

It's also broken for all other apps that have not yet requested root.

micw commented 5 years ago

When I install a non-repackaged manager, su works and finds the manager. When I remove it, the issue reappears.

androidacy-user commented 5 years ago

Might be similar or similarly caused by whatever causes #1788

topjohnwu commented 5 years ago

Use the latest canary build. The database is not properly setup in your case.

micw commented 5 years ago

@topjohnwu I'm on latest, there is no update. Can you point out how to fix this? Should a reinstall + a new repack do the job?

Edit: I just tried it, solved it the following way: