search

topjohnwu / Magisk

The Magic Mask for Android
GNU General Public License v3.0
47.6k stars 12.09k forks source link

Can't launch MagiskHide #1818

Closed Minikea closed 5 years ago

Minikea commented 5 years ago

When I toggle MagiskHide in manager, it became instable If I close and launch manager again it will not detect magisk. If I test in terminal:

magiskhide --enable
read (4 != 0) failed with 0: Success"

magisk_log_20190905_163809.log logcat.log

Honor 9 (STF-L09) on Android 7.0 with Magisk Canary 19.4-736729f5

osm0sis commented 5 years ago

Sounds related to the major su shell regression I reported to @topjohnwu awhile back. Basically every second su -c command would show "Permission denied" and the logs would show "4 != 0".

I think https://github.com/topjohnwu/Magisk/commit/cdb53ca0490c03f8307e53baf0f648baa7af3511 is supposed to fix it, so we'll have to see in the next Canary and make sure. :+1:

osm0sis commented 5 years ago

@geek85 Try with 19308 and report back! :slightly_smiling_face:

Minikea commented 5 years ago

same problem with canary 19308 and 19403

topjohnwu commented 5 years ago

Cannot reproduce as of the latest canary release

Minikea commented 5 years ago

Still present with 19406. Could a factory reset resolve the problem ? Screenshot_20191008-104039

Minikea commented 4 years ago

The problem was inside magisk.db I recreated the database from SQL instructions I found here and replaced the DB with the new one. After a reboot, no more problem.

osm0sis commented 4 years ago

So uninstalling and reinstalling Magisk probably also would have worked. :+1: