Install modules without having to directly open manager

[androidacy-user]

I'd like to see the ability to flash modules without directly opening the manager, eg magisk manager registers itself as a handler for .zip files so I can tap on it from a file manager, and magisk manager offers to flash (with a confirmation dialogue, eg " $APP is requesting you to install a magisk module named $MODID! Do you wish to continue?"

The flow would be: 1) Download zip from anywhwere 2) Tap open on the file downloaded dialog, like every other file you download 3) One of the options is Magisk Manager 4) It initiates the usual install process (maybe with a confirmation dialog, for security reasons)

[Marblog]

That's a good idea ！ I want it too

[Cyrupruk89]

But modules are .zip so this means when you click on nonmodule .zip file it shows you magisk manager. And thats annoying if you aren't flashing modules everyday.

[Cyrupruk89]

Bad idea

[androidacy-user]

@Cyrupruk89 it's only a default if you set it as such, otherwise it'll still show you the other apps that can open .zip files

[RikkaW]

The main problem is, it may be the easiest way for 💩 apps to detect Magisk. They can query apps that can handle ".zip" and check if the title is "Magisk Manager".

[skittles9823]

@RikkaW if you repackage magisk then that's not an issue.

[adpoliak]

If this does get implemented, it needs to have means to prevent an exploit kit from performing drive-by module installs, akin to what Android's Compatibility Definition Documents say. Specifically, guideline C-0-6 in that section, which states that "the app that requests the installation [...] MUST have been granted permission by the user to install apps from unknown sources".
Then, document the suggestion of whitelisting the user's file manager and not their browser(s).

Can't completely keep users from shooting themselves in the foot, but you can at least ship the gun and bullets in separate boxes.

[skittles9823]

@adpoliak yea, could also use a confirmation prompt in magisk for it too I'd imagine.

[aramix]

Is it really that hard doing that from inside the manager itself? :D

[androidacy-user]

It is 1-2 extra steps. More for pure convenience for those of us who sideload a lot of module

[programminghoch10]

What about a batch install feature? If you would be able to select multiple zips in the manager to flash after one another there wouldn't be a need for an easier zip selection mechanism 🤔

[androidacy-user]

What about a batch install feature? If you would be able to select multiple zips in the manager to flash after one another there wouldn't be a need for an easier zip selection mechanism 🤔

I was thinking more you don't have to actually open manager to install/sideload a module

[zgfg]

@RikkaW if you repackage magisk then that's not an issue.

You repackage MM and an exploit cannot find it among a hundred of installed apps. But with this, the app trying to find MM would have a small number of apps (zip handlers) to somehow investigate (by the footprint/signature, suspicious random package name, etc) to guess that the particular zip handler is possibly repackaged Magisk Manager

[zgfg]

What about a batch install feature? If you would be able to select multiple zips in the manager to flash after one another there wouldn't be a need for an easier zip selection mechanism 🤔

I was thinking more you don't have to actually open manager to install/sideload a module

Tap to the MM Canary icon and you have shortcuts to SuperUser, MagiskHide and Modules

Maybe an additional shortcut Install module, directly opening File Manager

[androidacy-user]

@topjohnwu thanks very much!!! 🥳