topjohnwu / Magisk

The Magic Mask for Android
GNU General Public License v3.0
47.6k stars 12.09k forks source link

Magisk canary 122b4d6 will break OP7T fingerprint unlock #2803

Closed sabpprook closed 4 years ago

sabpprook commented 4 years ago

OnePlus 7T HD1900 OOS India 10.3.2.HD65AA

It only happened on https://github.com/topjohnwu/Magisk/commit/122b4d66b62db2ff6d5c6aa02933c33f121217d2, previous build https://github.com/topjohnwu/Magisk/commit/a62bdc58cb2e06128b82d332ba1f4e72f5700269 works fine. I'm not able to get logcat right now, sorry for this.

0xCCD commented 4 years ago

Is it patched with magisk or stock ?

fresh from OTA on my sdcard, not patched

ekka1993 commented 4 years ago

Thanks, i Still has problem with fp, i Will try a new boot img IF it Will work

ekka1993 commented 4 years ago

Is your fp working with 10.5.8 and magisk ?

0xCCD commented 4 years ago

Thanks, i Still has problem with fp, i Will try a new boot img IF it Will work

check this https://forums.oneplus.com/threads/enrollment-was-not-completed-fingerprint-registration-error.1218379/page-2#post-21617960

0xCCD commented 4 years ago

Is your fp working with 10.5.8 and magisk ?

Yes it is working but there are two different issues atm with fingerprint. one of them was caused by Magisk update another is caused while flashing through fastboot

ekka1993 commented 4 years ago

Flashing with adb/fastboot cant be solved right now ? Or am i wrong ?

0xCCD commented 4 years ago

As far as I know you can only solve the issue caused by Magisk, the other issue is caused by a damaged partition which need to get fixed with a software update from Oneplus

ekka1993 commented 4 years ago

I Will try reflash a new magisk boot img and see IF it works

0xCCD commented 4 years ago

v20.4 and latest canary works fine for me

ekka1993 commented 4 years ago

Same error so have to wait for oneplus to slove it.

New boot img magisk 20.4 and latest canary. 20414

bittylicious commented 4 years ago

I just want to confirm with you that I have this error still, and I never flashed anything from fastboot manually.

My error (which granted is NOT the issue on this issue) came about when I had Canary (probably 20410 or 20411, and then upgraded to the latest OnePlus version (10.5.6 in my region). This would have been a full ROM download, not the OTA patch, so maybe that also involves a flash of other partitions? I'm not sure.

0xCCD commented 4 years ago

I just want to confirm with you that I have this error still, and I never flashed anything from fastboot manually.

My error (which granted is NOT the issue on this issue) came about when I had Canary (probably 20410 or 20411, and then upgraded to the latest OnePlus version (10.5.6 in my region). This would have been a full ROM download, not the OTA patch, so maybe that also involves a flash of other partitions? I'm not sure.

I usually also have full rom updates, but as long it is flashed through Local Upgrade functionality of Oxygen OS it should be safe. Probably you can ask on oneplus forum