search

topjohnwu / Magisk

The Magic Mask for Android
GNU General Public License v3.0
47.6k stars 12.09k forks source link

MagiskDetector #2836

Closed jbro129 closed 4 years ago

jbro129 commented 4 years ago

I came across this https://github.com/vvb2060/MagiskDetector

It can detect su and Magisk even with Magisk hide selected for the app. I just thought I'd bring this to your attention @topjohnwu in case you weren't aware already.

Love your work btw

osm0sis commented 4 years ago

Yeah @vvb2060 is our homie.

kam821 commented 4 years ago

MagiskHide mounts detection bug is already reported, you have to wait. https://github.com/topjohnwu/Magisk/issues/2406

vvb2060 commented 4 years ago

@kam821 In fact, this app uses 5 independent methods to detect. 😆 I think the mount detection method of other apps is too simple.

jbro129 commented 4 years ago

@kam821 In fact, this app uses 5 independent methods to detect. I think the mount detection method of other apps is too simple.

Sounds like detecting Magisk is pretty easy to do. Are methods of preventing these detection methods being worked on? I know some app developers don't want their users being rooted or having Magisk regardless if Magisk is even affecting their app specifically.