search

topjohnwu / Magisk

The Magic Mask for Android
GNU General Public License v3.0
47.09k stars 11.91k forks source link

MagiskInit Incompatible with MTK devices #3042

Closed mrmazakblu closed 3 years ago

mrmazakblu commented 4 years ago

Continued from https://github.com/topjohnwu/Magisk/issues/3040

Magisk patches boot.img. Log shows complete. But magisk.init is not run on boot.

same result with 20.4 and latest canary. Previous similar issue with devices on android 11 and boot.img has no 'apex' dir.

This problem is on android 10 and the boot.img does have 'apex' dir,

can confirm patched image is flashed by spflash readback. It is same image as was flashed.

magisk_canary-boot-logcat.txt magisk_install_log_2020-08-03T065156Z.log

magisk_patched.zip

Crescendo-BLYAT commented 3 years ago

@topjohnwu do you have some way to see what changes @vvb2060 made to his released magisk that allows it to work.

Yes I am confirming that I now see root permission on my mtk device, by using custom update chanel that @vvb2060 shared in this issue thread.

During install , magisk manager showed magisk version 21.1. The official 21.1 did not work though.

I think this one, correct me if I'm wrong... https://github.com/vvb2060/Magisk/commit/1e0f96d0fdd7ada50859de743eabb9779cc7b29c

mrmazakblu commented 3 years ago

More confused information.

I had the aabe2696(21101) version of magisk installed, and phone is rooted with it

I changed update chanel back to beta, instead of vvn2060's custom chanel. Allowed a live update from manager. The log showed successful flashing to the detected magisk patched boot Did a reboot and only to find that manager still shows the old version as installed.

Crescendo-BLYAT commented 3 years ago

OK latest alpha branch from @vvb2060 fixed everything... 7ff22c6-alpha (315) (14) boot is dang fast now, no bug/issue. Thanks so much.

EDIT: Latest @topjohnwu canary also fixed the issue. Thanks so much.

vvb2060 commented 3 years ago

21.2 fixed