topjohnwu / Magisk

The Magic Mask for Android
GNU General Public License v3.0
47.61k stars 12.09k forks source link

Ugly icon for Hidden (repackaged) Magisk Manager #3238

Closed zgfg closed 4 years ago

zgfg commented 4 years ago

Upon Hiding Magisk Manqger, the new, repackaged app gets ugly, oversized, default Android icon.

Repackaging process offers you additionally to place a shortcut to the Home screen

With that, I have two icons on the Hone screen Screenshot_2020-10-04-00-11-27-936_com miui home

Both icons open the repackaged Canary Magisk Manager 303

zgfg commented 4 years ago

I'm not sure for the numbers but till Canary Magisk 294 or so, repackaged Manager still had the same standard Magisk Manager icon

And I saw this ugly icon first time with Canary Magisk 299 or so

wangdaning commented 4 years ago

Can't you just long press the app in the app drawer and change icon?

ghost commented 4 years ago

Me too. The magisk icon disappears and changes to an android icon. Until I install it again and the results are the same, maybe I have to repack it manually.

sr1canskhsia commented 4 years ago

Guys please read the FAQ. This is intended behaviour.

zgfg commented 4 years ago

FAQ says: "You can also manually ask the app to create the icon in Magisk Manager settings." - screenshot: IMG_20201004_094014

Screenshot from the repackaged Manager attached, where is that option? I see only a setting to add the shortcut but as described above, shortcut does not fully work as the icon for the app Screenshot_2020-10-04-08-00-25-077_kiohcaw fydn

phil19989 commented 4 years ago

I have the same problem, except that once I repack Magisk Manager and then add a shortcut to the home screen, both apps have the ugly android icon. Strangely though, unlike what zgfg has reported, both my apps have the long press functionality working.

Screenshot_20201004-184357_One UI Home Screenshot_20201004-184352_One UI Home

Madis0 commented 4 years ago

Are there actually apps that check Magisk by its icon now? That's just... scary.

topjohnwu commented 4 years ago

https://topjohnwu.github.io/Magisk/faq.html#q-after-i-hidden-magisk-manager-the-app-icon-is-broken

zgfg commented 4 years ago

https://topjohnwu.github.io/Magisk/faq.html#q-after-i-hidden-magisk-manager-the-app-icon-is-broken

I see you closed, but then just fix your FAQ, there is no such setting to change the icon (only to make the shortcut, but it doesn't provide the same functionality)

Screenrecording below, showing the whole process of Hiding Magisk Manager: https://mega.nz/file/V0sVkCxY#RDOpE0sLAx9Z1zNUjHcFm2wHGOWPOAMBq-4Us9ZSjCM

androidacy-user commented 4 years ago

See, but the FAQ isn't wrong it never says it gets the icon back, it explicitly says creating a shortcut which, for me anyway, has been he expected icon

AndnixSH commented 4 years ago

Are there actually apps that check Magisk by its icon now? That's just... scary.

I'm not sure but I had tried to play a game with a game protection called Xigncode, detected any hidden apps, so it's possible it might scanning apps list and detect icons.

zgfg commented 4 years ago

See, but the FAQ isn't wrong it never says it gets the icon back, it explicitly says creating a shortcut which, for me anyway, has been he expected icon

Screenshot and citation from the FAQ - at the time of reporting - is in my post above: "You can also manually ask the app to create the icon in Magisk Manager settings." I see exlpicitely the word icon (not shortcut, in that sentence), and if you watch my previously linked screenrecording movie you will see the icon and that additional shortcut, one alongside the other as two different entities: with different look and more imortant, different long-tap functionalities

Anyway, better not to waste time on issue that was closed