Closed zgfg closed 4 years ago
I'm not sure for the numbers but till Canary Magisk 294 or so, repackaged Manager still had the same standard Magisk Manager icon
And I saw this ugly icon first time with Canary Magisk 299 or so
Can't you just long press the app in the app drawer and change icon?
Me too. The magisk icon disappears and changes to an android icon. Until I install it again and the results are the same, maybe I have to repack it manually.
Guys please read the FAQ. This is intended behaviour.
FAQ says: "You can also manually ask the app to create the icon in Magisk Manager settings." - screenshot:
Screenshot from the repackaged Manager attached, where is that option? I see only a setting to add the shortcut but as described above, shortcut does not fully work as the icon for the app
I have the same problem, except that once I repack Magisk Manager and then add a shortcut to the home screen, both apps have the ugly android icon. Strangely though, unlike what zgfg has reported, both my apps have the long press functionality working.
Are there actually apps that check Magisk by its icon now? That's just... scary.
https://topjohnwu.github.io/Magisk/faq.html#q-after-i-hidden-magisk-manager-the-app-icon-is-broken
I see you closed, but then just fix your FAQ, there is no such setting to change the icon (only to make the shortcut, but it doesn't provide the same functionality)
Screenrecording below, showing the whole process of Hiding Magisk Manager: https://mega.nz/file/V0sVkCxY#RDOpE0sLAx9Z1zNUjHcFm2wHGOWPOAMBq-4Us9ZSjCM
I had Magisk Chanary channel, and already Magisk Manager 303
Upon hiding the Magisk Manager, it dropped to 302, asking me to update again to 303 (no big deal but strange?!)
There is no setting to change the icon but only to install the Shortcut
Shortcut installed (already while hiding, when it popped-up and suggested), but observe a difference with long tap functionality between the 'ugly' icon (on the left) and shortcut (standard Magisk icon look, on the right)
See, but the FAQ isn't wrong it never says it gets the icon back, it explicitly says creating a shortcut which, for me anyway, has been he expected icon
Are there actually apps that check Magisk by its icon now? That's just... scary.
I'm not sure but I had tried to play a game with a game protection called Xigncode, detected any hidden apps, so it's possible it might scanning apps list and detect icons.
See, but the FAQ isn't wrong it never says it gets the icon back, it explicitly says creating a shortcut which, for me anyway, has been he expected icon
Screenshot and citation from the FAQ - at the time of reporting - is in my post above: "You can also manually ask the app to create the icon in Magisk Manager settings." I see exlpicitely the word icon (not shortcut, in that sentence), and if you watch my previously linked screenrecording movie you will see the icon and that additional shortcut, one alongside the other as two different entities: with different look and more imortant, different long-tap functionalities
Anyway, better not to waste time on issue that was closed
Upon Hiding Magisk Manqger, the new, repackaged app gets ugly, oversized, default Android icon.
Repackaging process offers you additionally to place a shortcut to the Home screen
With that, I have two icons on the Hone screen
Ugly, oversized, green default Androud icon, named Manager (name I chose when repackaging) - left on the screenshot. By long tapping, that icon provides direct access to Modules, MagiskHide and.Superuser
Standard Magisk icon, naned Magisk Manager (not the given, repackaged name) - right on the screenshot below) Long tapping to that shortcut offers only Remove - hence, that icon does not provide long tap Magisk functionality and therefore cannot be used to substitute for the uggly icon given with the repackaged Magisk Manqger
Both icons open the repackaged Canary Magisk Manager 303