search

topjohnwu / Magisk

The Magic Mask for Android
GNU General Public License v3.0
47.61k stars 12.09k forks source link

Option to magisk hide from all in MagiskHide screen #3456

Closed vinnom closed 3 years ago

vinnom commented 3 years ago

Considering that converting MagiskHide to whitelisted based would be hard, it would be nice to have a "hide from all" option to check all apps from checklist, considering that apps which will not be blacklisted are considerable less frequent than the ones that will be. Then uncheck the ones we don't want blacklisted would be easier than check all the others

DanGLES3 commented 3 years ago

That would not be good, due to the hacky way Magisk Hide works it's only designed to be used on a few apps at a time, using it on all apps (unnecessarily) would lead to potential system instability

vinnom commented 3 years ago

hmm, I didn't know that, but I do it for almost all my apps for quite some time now and I didn't face any system instability, neither on AOSP ROMs or MIUI (device beryllium)

DanGLES3 commented 3 years ago

hmm, I didn't know that, but I do it for almost all my apps for quite some time now and I didn't face any system instability, neither on AOSP ROMs or MIUI (device beryllium)

Still, there is no benefit on doing that, if an app works just fine without Magisk Hide then using it on the app is pointless and it's just risking potential instability

The amount of apps that actively check root is insignificant in comparison to the apps that don't

topjohnwu commented 3 years ago

@vinnom if you select all apps, your device will be very unstable...

vinnom commented 3 years ago

as I said, I do that for some time already everytime I change ROM and I didn't had any issues regarding stability until now. But if you guys say so, I'll stop doing that to avoid potential issues. I really didn't know it could lead unstability.