search

topjohnwu / Magisk

The Magic Mask for Android
GNU General Public License v3.0
47.68k stars 12.1k forks source link

Dolby Module in Dynamic Partition #3578

Closed reiryuki closed 3 years ago

reiryuki commented 3 years ago

Hi, I have Dolby Atmos/Audio modules. We need to modify /vendor/etc/vintf/manifest.xml directly to make Dolby dms hwservice working. But in dynamic partitions devices, we are not be able to modify any files directly, so, Dolby module fails to be working. Any workaround for this?

Didgeridoohan commented 3 years ago

Yes, the module should edit the files systemlessly... That's what Magisk is for. All relevant details are in the docs: https://topjohnwu.github.io/Magisk/guides.html

But this isn't the place for this kind of posts... Please close.

reiryuki commented 3 years ago

@Didgeridoohan But I hope Magisk can solve hwservice addition systemlessly without needs of modifying file directly, in future, like pre-init mount support. Due to dynamic partitions devices. Thanks.

androidacy-user commented 3 years ago

@Didgeridoohan But I hope Magisk can solve hwservice addition systemlessly without needs of modifying file directly, in future, like pre-init mount support. Due to dynamic partitions devices. Thanks.

Magisk runs mostly post init iirc to prevent some bootloops

reiryuki commented 3 years ago

@unixandria-xda no sir, my dolby magisk no need .rc to run. It's need hidl addition at manifest.xml.

androidacy-user commented 3 years ago

@unixandria-xda no sir, my dolby magisk no need .rc to run. It's need hidl addition at manifest.xml.

I meant it's not possible to run pre-init as magisk execs original init then does magisk stuff like mount modules. Hence why boot animation replacement can be hit and miss.

Honestly your best bet is to kill the service and restart it in a late start service script

DannyGitee commented 3 years ago

Screenshot_20210315-013553.png

How can I fix it and flazh it into my pixel 4xl..