topjohnwu / Magisk

The Magic Mask for Android
GNU General Public License v3.0
47.07k stars 11.9k forks source link

Is it possible to get notified or automatically update modules when updates are released? #3656

Open asdsadsaasd12312132 opened 3 years ago

asdsadsaasd12312132 commented 3 years ago

I noticed that several of my modules were outdated by a year because I hadn't checked in so long. I would like to keep them updated but don't want to have to check manually frequently. Is it possible to get notifications or automatically update?

Haus3master commented 3 years ago

I hope @topjohnwu labels this query as 'enhancement' and hopefully brings this feature in the next update....

IanWorthington commented 3 years ago

Given the current problems with 21.2, I would suggest that letting it update automatically may not be a good idea :(

vvb2060 commented 3 years ago

Before updating, you should read the changelog, automatic updates are not a good idea.

IanWorthington commented 3 years ago

Before updating, you should read the changelog, automatic updates are not a good idea.

As I did for 21.2 last night. Looked innocuous. How wrong can one be? :(

Better advice might be wait until you have a problem and then see what's the latest version which hasn't got issues raised against it either here or on xda? To that end, the ability in the manager to install versions other than the most recent might be useful.

selurvedu commented 3 years ago

@vvb2060 I'd like to be notified that an update is available. Deciding whether to install it or not should be up to the user.

osm0sis commented 2 years ago

Well, there is no modules repo within the app anymore, but there is a plan for adding 3rd party repos as a setting within the app, so I guess this can remain open for that.

yujincheng08 commented 2 years ago

https://github.com/topjohnwu/Magisk/commit/bc0c1980db62c15c8dd55ffc7f53521410f5706c

osm0sis commented 2 years ago

Hmm, not sure if that actually notifies when there's an update or not from reading through the commit. 🤔

MartinX3 commented 2 years ago

Even if there is no repo anymore and modules contain their own update url, there should be a setting in the App to as example check every 24 hours for new module versions and notify the user.

breversa commented 2 years ago

There's a app for this: Fox's Magisk Module Manager https://f-droid.org/packages/com.fox2code.mmm.fdroid/

osm0sis commented 2 years ago

Again, modules can still update themselves in the current format, so a feature for a notification when an update is available is still a valid request.

MartinX3 commented 2 years ago

Also they don't autoupdate (at my side). In my case I need to regular visit the Magisk App and wait in the Modules Section that every module got checked for a new version.

osm0sis commented 2 years ago

Also they don't autoupdate (at my side). In my case I need to regular visit the Magisk App and wait in the Modules Section that every module got checked for a new version.

Exactly, so the current request would be for that update check to occur in the background and for a notification when an update is available.

xerta555 commented 2 years ago

Also they don't autoupdate (at my side). In my case I need to regular visit the Magisk App and wait in the Modules Section that every module got checked for a new version.

Exactly, so the current request would be for that update check to occur in the background and for a notification when an update is available.

If you look at it from the outside, that users are now checking for updates themselves or using another application or not checking at all, you realize that there is a problem.

DemonoidMaster commented 3 months ago

Old thread i know but i agree it would be nice if it could check for module updates at the same time as for magisk updates through a built in timer the user can set, why isn't there a setting for that ? Magisk just checks for updates of itself whenever it wants but how often, dunno, doesn't tell the user, would be nice having it check weekly/monthly instead of everyday if that's what it does