topjohnwu / Magisk

The Magic Mask for Android
GNU General Public License v3.0
47.58k stars 12.08k forks source link

Manual Patching for Samsung Tab S7+: Unable to repack boot image #3869

Closed null-von-sushi closed 3 years ago

null-von-sushi commented 3 years ago

READ BEFORE OPENING ISSUES

Canary: `b76c80e2 (21410)

cat /proc/mounts from an unprivileged terminal:

/dev/block/dm-0 / ext4 ro,seclabel,relatime,errors=remount-ro,i_version 0 0
tmpfs /dev tmpfs rw,seclabel,nosuid,relatime,size=2668404k,nr_inodes=667101,mode=755 0 0
devpts /dev/pts devpts rw,seclabel,relatime,mode=600,ptmxmode=000 0 0
none /dev/memcg cgroup rw,relatime,memory 0 0
none /dev/blkio cgroup rw,nosuid,nodev,noexec,relatime,blkio 0 0
none /dev/cg2_bpf cgroup2 rw,nosuid,nodev,noexec,relatime 0 0
none /dev/cpuctl cgroup rw,nosuid,nodev,noexec,relatime,cpu 0 0
none /dev/cpuset cgroup rw,nosuid,nodev,noexec,relatime,cpuset,noprefix,release_agent=/sbin/cpuset_release_agent 0 0
none /dev/stune cgroup rw,nosuid,nodev,noexec,relatime,schedtune 0 0
none /dev/freezer cgroup rw,relatime,freezer 0 0
adb /dev/usb-ffs/adb functionfs rw,relatime 0 0
proc /proc proc rw,relatime,gid=3009,hidepid=2 0 0
sysfs /sys sysfs rw,seclabel,relatime 0 0
selinuxfs /sys/fs/selinux selinuxfs rw,relatime 0 0
debugfs /sys/kernel/debug debugfs rw,seclabel,relatime 0 0
tracefs /sys/kernel/debug/tracing tracefs rw,seclabel,relatime 0 0
bpf /sys/fs/bpf bpf rw,nosuid,nodev,noexec,relatime 0 0
pstore /sys/fs/pstore pstore rw,seclabel,nosuid,nodev,noexec,relatime 0 0
tmpfs /mnt tmpfs rw,seclabel,nosuid,nodev,noexec,relatime,size=2668404k,nr_inodes=667101,mode=755,gid=1000 0 0
tmpfs /mnt/sde tmpfs rw,seclabel,relatime,size=2668404k,nr_inodes=667101,mode=700 0 0
/dev/block/bootdevice/by-name/persist /mnt/vendor/persist ext4 rw,seclabel,nosuid,nodev,noatime,journal_checksum,noauto_da_alloc,i_version 0 0
/dev/block/bootdevice/by-name/efs /mnt/vendor/efs ext4 rw,seclabel,nosuid,nodev,noatime,journal_checksum,noauto_da_alloc,i_version 0 0
/data/knox/secure_fs/enc_media /mnt/shell/enc_emulated sdcardfs rw,nosuid,nodev,noexec,noatime,fsuid=1000,fsgid=1000,gid=9997,multiuser,derive_gid,default_normal,reserved=20MB 0 0
/data/media /mnt/runtime/default/emulated sdcardfs rw,nosuid,nodev,noexec,noatime,fsuid=1023,fsgid=1023,gid=1015,multiuser,mask=6,derive_gid,default_normal,reserved=20MB,unshared_obb 0 0
/data/media /mnt/runtime/read/emulated sdcardfs rw,nosuid,nodev,noexec,noatime,fsuid=1023,fsgid=1023,gid=9997,multiuser,mask=23,derive_gid,default_normal,reserved=20MB,unshared_obb 0 0
/data/media /mnt/runtime/write/emulated sdcardfs rw,nosuid,nodev,noexec,noatime,fsuid=1023,fsgid=1023,gid=9997,multiuser,mask=7,derive_gid,default_normal,reserved=20MB,unshared_obb 0 0
/data/media /mnt/runtime/full/emulated sdcardfs rw,nosuid,nodev,noexec,noatime,fsuid=1023,fsgid=1023,gid=9997,multiuser,mask=7,derive_gid,default_normal,reserved=20MB,unshared_obb 0 0
/dev/block/vold/public:179,1 /mnt/media_rw/6594-A101 sdfat rw,nosuid,nodev,noexec,noatime,fs=exfat,uid=1023,gid=1023,fmask=0007,dmask=0007,allow_utime=0020,codepage=cp437,iocharset=iso8859-1,utf8,namecase=0,adj_req,symlink=0,bps=512,errors=remount-ro 0 0
/dev/block/vold/public:179,1 /mnt/secure/asec sdfat rw,nosuid,nodev,noexec,noatime,fs=exfat,uid=1023,gid=1023,fmask=0007,dmask=0007,allow_utime=0020,codepage=cp437,iocharset=iso8859-1,utf8,namecase=0,adj_req,symlink=0,bps=512,errors=remount-ro 0 0
/mnt/media_rw/6594-A101 /mnt/runtime/default/6594-A101 sdcardfs rw,nosuid,nodev,noexec,noatime,fsuid=1023,fsgid=1023,gid=1015,mask=6,nocache 0 0
/mnt/media_rw/6594-A101 /mnt/runtime/read/6594-A101 sdcardfs rw,nosuid,nodev,noexec,noatime,fsuid=1023,fsgid=1023,gid=9997,mask=18,nocache 0 0
/mnt/media_rw/6594-A101 /mnt/runtime/write/6594-A101 sdcardfs rw,nosuid,nodev,noexec,noatime,fsuid=1023,fsgid=1023,gid=9997,mask=18,nocache 0 0
/mnt/media_rw/6594-A101 /mnt/runtime/full/6594-A101 sdcardfs rw,nosuid,nodev,noexec,noatime,fsuid=1023,fsgid=1023,gid=9997,mask=7,nocache 0 0
tmpfs /apex tmpfs rw,seclabel,nosuid,nodev,noexec,relatime,size=2668404k,nr_inodes=667101,mode=755 0 0
/dev/block/dm-4 /apex/com.android.media@301500800 ext4 ro,dirsync,seclabel,nodev,noatime,i_version 0 0
/dev/block/dm-4 /apex/com.android.media ext4 ro,dirsync,seclabel,nodev,noatime,i_version 0 0
/dev/block/dm-5 /apex/com.android.tzdata@293200000 ext4 ro,dirsync,seclabel,nodev,noatime,i_version 0 0
/dev/block/dm-5 /apex/com.android.tzdata ext4 ro,dirsync,seclabel,nodev,noatime,i_version 0 0
/dev/block/dm-6 /apex/com.android.media.swcodec@301500900 ext4 ro,dirsync,seclabel,nodev,noatime,i_version 0 0
/dev/block/dm-6 /apex/com.android.media.swcodec ext4 ro,dirsync,seclabel,nodev,noatime,i_version 0 0
/dev/block/loop5 /apex/com.android.resolv@290000000 ext4 ro,dirsync,seclabel,nodev,noatime,i_version 0 0
/dev/block/loop5 /apex/com.android.resolv ext4 ro,dirsync,seclabel,nodev,noatime,i_version 0 0
/dev/block/loop6 /apex/com.android.apex.cts.shim@1 ext4 ro,dirsync,seclabel,nodev,noatime,i_version 0 0
/dev/block/loop6 /apex/com.android.apex.cts.shim ext4 ro,dirsync,seclabel,nodev,noatime,i_version 0 0
/dev/block/loop7 /apex/com.android.runtime@1 ext4 ro,dirsync,seclabel,nodev,noatime,i_version 0 0
/dev/block/loop7 /apex/com.android.runtime ext4 ro,dirsync,seclabel,nodev,noatime,i_version 0 0
/dev/block/loop8 /apex/com.android.conscrypt@290000000 ext4 ro,dirsync,seclabel,nodev,noatime,i_version 0 0
/dev/block/loop8 /apex/com.android.conscrypt ext4 ro,dirsync,seclabel,nodev,noatime,i_version 0 0
/dev/block/platform/soc/1d84000.ufshc/by-name/metadata /metadata ext4 rw,seclabel,nosuid,nodev,noatime,journal_checksum,noauto_da_alloc,i_version 0 0
/dev/block/dm-2 /product ext4 ro,seclabel,relatime,i_version 0 0
/dev/block/dm-1 /vendor ext4 ro,seclabel,relatime,i_version 0 0
/dev/block/bootdevice/by-name/apnhlos /vendor/firmware_mnt vfat ro,context=u:object_r:firmware_file:s0,relatime,gid=1000,fmask=0337,dmask=0227,codepage=437,iocharset=iso8859-1,shortname=lower,errors=remount-ro 0 0
/dev/block/bootdevice/by-name/dsp /vendor/dsp ext4 ro,seclabel,nosuid,nodev,relatime,i_version 0 0
/dev/block/dm-3 /odm ext4 ro,seclabel,relatime,i_version 0 0
/dev/block/platform/soc/1d84000.ufshc/by-name/prism /prism ext4 ro,seclabel,relatime,i_version 0 0
/dev/block/platform/soc/1d84000.ufshc/by-name/optics /optics ext4 ro,seclabel,relatime,i_version 0 0
tmpfs /sbin tmpfs rw,seclabel,relatime,size=2668404k,nr_inodes=667101,mode=755 0 0
/dev/block/dm-0 /sbin/sswap ext4 ro,seclabel,relatime,errors=remount-ro,i_version 0 0
/dev/block/dm-0 /sbin/knox_changer ext4 ro,seclabel,relatime,errors=remount-ro,i_version 0 0
/sbin/.magisk/block/product /sbin/.magisk/mirror/product ext4 ro,seclabel,relatime,i_version 0 0
/sbin/.magisk/block/vendor /sbin/.magisk/mirror/vendor ext4 ro,seclabel,relatime,i_version 0 0
/sbin/.magisk/block/data /sbin/.magisk/mirror/data f2fs rw,lazytime,seclabel,relatime,background_gc=on,discard,no_heap,user_xattr,inline_xattr,acl,inline_data,inline_dentry,extent_cache,mode=adaptive,active_logs=6,reserve_root=32768,reserve_core=1280,resuid=0,resgid=5678,usrquota,grpquota,alloc_mode=default,fsync_mode=nobarrier 0 0
/sbin/.magisk/block/system_root /sbin/.magisk/mirror/system_root ext4 ro,seclabel,relatime,errors=remount-ro,i_version 0 0
/sbin/.magisk/block/data /sbin/.magisk/modules f2fs rw,lazytime,seclabel,relatime,background_gc=on,discard,no_heap,user_xattr,inline_xattr,acl,inline_data,inline_dentry,extent_cache,mode=adaptive,active_logs=6,reserve_root=32768,reserve_core=1280,resuid=0,resgid=5678,usrquota,grpquota,alloc_mode=default,fsync_mode=nobarrier 0 0
none /acct cgroup rw,nosuid,nodev,noexec,relatime,cpuacct 0 0
none /config configfs rw,nosuid,nodev,noexec,relatime 0 0
/dev/block/bootdevice/by-name/cache /cache ext4 rw,seclabel,nosuid,nodev,noatime,journal_checksum,noauto_da_alloc,i_version 0 0
/dev/block/bootdevice/by-name/sec_efs /efs ext4 rw,seclabel,nosuid,nodev,noatime,journal_checksum,noauto_da_alloc,i_version 0 0
/dev/block/bootdevice/by-name/dqmdbg /dqmdbg ext4 rw,seclabel,nosuid,nodev,noatime,journal_checksum,noauto_da_alloc,i_version 0 0
/dev/block/bootdevice/by-name/spu /spu ext4 rw,seclabel,nosuid,nodev,noatime,journal_checksum,noauto_da_alloc,i_version 0 0
/dev/block/bootdevice/by-name/keydata /keydata ext4 rw,seclabel,nosuid,nodev,noatime,journal_checksum,noauto_da_alloc,i_version 0 0
/dev/block/bootdevice/by-name/keyrefuge /keyrefuge ext4 rw,seclabel,nosuid,nodev,noatime,journal_checksum,noauto_da_alloc,i_version 0 0
/dev/block/bootdevice/by-name/omr /omr ext4 rw,seclabel,nosuid,nodev,noatime,journal_checksum,noauto_da_alloc,i_version 0 0
/dev/block/bootdevice/by-name/userdata /data f2fs rw,lazytime,seclabel,nosuid,nodev,noatime,background_gc=on,discard,no_heap,user_xattr,inline_xattr,acl,inline_data,inline_dentry,extent_cache,mode=adaptive,active_logs=6,reserve_root=32768,reserve_core=1280,resuid=0,resgid=5678,usrquota,grpquota,alloc_mode=default,fsync_mode=nobarrier 0 0
tmpfs /storage tmpfs rw,seclabel,nosuid,nodev,noexec,relatime,size=2668404k,nr_inodes=667101,mode=755,gid=1000 0 0
/data/media /storage/emulated sdcardfs rw,nosuid,nodev,noexec,noatime,fsuid=1023,fsgid=1023,gid=1015,multiuser,mask=6,derive_gid,default_normal,reserved=20MB,unshared_obb 0 0
/mnt/media_rw/6594-A101 /storage/6594-A101 sdcardfs rw,nosuid,nodev,noexec,noatime,fsuid=1023,fsgid=1023,gid=1015,mask=6,nocache 0 0
tmpfs /storage/self tmpfs rw,seclabel,nosuid,nodev,noexec,rel

atime,size=2668404k,nr_inodes=667101,mode=755,gid=1000 0 0

magisk_install_log.log

I am trying to patch the boot.img.lz4 for a Samsung Galaxy Tab S7+ (SM-T970) however it does not seem to want to patch the boot image. The Manager app is running on the tablet, and it is on Android 10. The boot image would be for a Android 11 update.

I have attached the bootfile I am trying to patch bellow in case it is helpful. Zip containing boot.img.lz4

osm0sis commented 3 years ago

Unpack it from .img.lz4 to .img first? The Magisk app specifically says .img or .tar as accepted file types for patching.

osm0sis commented 3 years ago

I've just unpacked it myself and confirmed there's nothing special about your boot.img, so follow the instructions and you'll likely be fine.

null-von-sushi commented 3 years ago

Sorry, you are correct. For some reason I thought I should feed Magisk Manager the LZ4. Thanks!