search

topjohnwu / Magisk

The Magic Mask for Android
GNU General Public License v3.0
48.28k stars 12.33k forks source link

[Feature Request] Add Export Magisk Installer zip file in Magisk App #4032

Closed Raspberry-Monster closed 3 years ago

Raspberry-Monster commented 3 years ago

Device: Android version: Android 11 Magisk version name: Magisk V22 Magisk version code: 22004

It is very important for some users to install Magisk in the recovery.Because some rom (Like MIUI) will replace third-party version of Recovery (Such as TWRP) to manufacturer ones. So If there is no any zip file , some user can't install Magisk conveniently because they cannot flash boot.img unless they use fastboot. So Could you please add Exporty Magisk Install Zip File in the Magisk App? Thank you !

pndwal commented 3 years ago

Whats wrong with changing .apk extension to .zip as per instructions?

Raspberry-Monster commented 3 years ago

Whats wrong with changing .apk extension to .zip as per instructions?

Well, It seems that there is nothing bad happened. But I think that it is better to make it shows in Magisk App because some rom (Especially Chinese Brand Rom) wil remove apk File automatically(Although you can disable it in the setting s.) And most people don't read wiki because there are too lazy or they just can't understand English.So they will have no idea if there is no instruction about install Magisk in custom recovery in Magisk App. So I open this issue. Anyway Thank you for replying me.

vvb2060 commented 3 years ago

https://github.com/topjohnwu/Magisk/commit/eaf4d8064b1112a65461f6ede0b2fd7e0a6d9d74 If you use in-app updates, we will save a copy of the apk to storage. If you update via external, just download the apk again.

Raspberry-Monster commented 3 years ago

eaf4d80 If you use in-app updates, we will save a copy of the apk to storage. If you update via external, just download the apk again.

OK Thank you. I will close this issue.