topjohnwu / Magisk

The Magic Mask for Android
GNU General Public License v3.0
47.59k stars 12.08k forks source link

Stuck at boot animation; magisk --remove-modules does not work #4083

Closed maxweisspoker closed 3 years ago

maxweisspoker commented 3 years ago

Device: Pixel 3 blueline Android version: 10 (LineageOS 17.1) Magisk version name: 22 Magisk version code: 483dbcd

This is a repost of #4082 because the github bot deleted it.

The device is a Pixel 3 blueline, ROM is stock lineage with Magisk v22 patched boot.img flashed in fastboot to both slots.

Earlier, I updated the modules Riru Core and Ruri Sui, and then rebooted, and now am stuck in the boot animation. While there, I can run adb commands and access su, but no changes I make seem to persist. I tried to run

adb wait-for-device shell magisk --remove-modules

as well as

adb wait-for-device shell su - -c 'magisk --remove-modules'

to run those as soon as possible, and neither worked. Neither did removing the module directory in /data/adb/modules/. None of those changes persisted, and all files/folders/modules were still present when I looked for them with adb during another failed reboot during the boot animation.

The dmesg output during the failed boot (while stuck at the boot animation) is here on my self-hosted pastebin clone, because it was too large to fit in the issue text.

And if I flash the stock Lineage boot.img without Magisk, I can boot, although of course nothing Magisk-related works.

The command "cat /proc/mounts" when run in the non-Magisk stock booted Lineage ROM reads:

mpfs /dev tmpfs rw,seclabel,nosuid,relatime,size=1809168k,nr_inodes=452292,mode=755 0 0
devpts /dev/pts devpts rw,seclabel,relatime,mode=600,ptmxmode=000 0 0
proc /proc proc rw,relatime,gid=3009,hidepid=2 0 0
sysfs /sys sysfs rw,seclabel,relatime 0 0
selinuxfs /sys/fs/selinux selinuxfs rw,relatime 0 0
tmpfs /mnt tmpfs rw,seclabel,nosuid,nodev,noexec,relatime,size=1809168k,nr_inodes=452292,mode=755,gid=1000 0 0
tmpfs /apex tmpfs rw,seclabel,nosuid,nodev,noexec,relatime,size=1809168k,nr_inodes=452292,mode=755 0 0
/dev/block/by-name/metadata /metadata ext4 rw,sync,seclabel,nosuid,nodev,noatime,discard,data=ordered 0 0
/dev/block/dm-0 / ext4 ro,seclabel,nodev,relatime 0 0
/dev/block/dm-1 /vendor ext4 ro,seclabel,relatime 0 0
/dev/block/dm-2 /product ext4 ro,seclabel,relatime 0 0
none /dev/blkio cgroup rw,nosuid,nodev,noexec,relatime,blkio 0 0
none /dev/cg2_bpf cgroup2 rw,nosuid,nodev,noexec,relatime 0 0
none /dev/cpuctl cgroup rw,nosuid,nodev,noexec,relatime,cpu 0 0
none /acct cgroup rw,nosuid,nodev,noexec,relatime,cpuacct 0 0
none /dev/cpuset cgroup rw,nosuid,nodev,noexec,relatime,cpuset,noprefix,release_agent=/sbin/cpuset_release_agent 0 0
none /dev/memcg cgroup rw,nosuid,nodev,noexec,relatime,memory 0 0
none /dev/stune cgroup rw,nosuid,nodev,noexec,relatime,schedtune 0 0
/dev/block/dm-0 /apex/com.android.runtime@1 ext4 ro,seclabel,relatime 0 0
/dev/block/dm-0 /apex/com.android.runtime ext4 ro,seclabel,relatime 0 0
/dev/block/dm-0 /apex/com.android.tzdata@290000000 ext4 ro,seclabel,relatime 0 0
/dev/block/dm-0 /apex/com.android.tzdata ext4 ro,seclabel,relatime 0 0
debugfs /sys/kernel/debug debugfs rw,seclabel,relatime 0 0
/dev/block/platform/soc/1d84000.ufshc/by-name/persist /mnt/vendor/persist ext4 rw,seclabel,nosuid,nodev,noatime,data=ordered 0 0
none /config configfs rw,nosuid,nodev,noexec,relatime 0 0
bpf /sys/fs/bpf bpf rw,nosuid,nodev,noexec,relatime 0 0
tracefs /sys/kernel/debug/tracing tracefs rw,seclabel,relatime 0 0
/dev/block/bootdevice/by-name/modem_a /vendor/firmware_mnt vfat ro,context=u:object_r:firmware_file:s0,relatime,uid=1000,gid=1000,fmask=0337,dmask=0227,codepage=437,iocharset=iso8859-1,shortname=lower,errors=remount-ro 0 0
tmpfs /storage tmpfs rw,seclabel,nosuid,nodev,noexec,relatime,size=1809168k,nr_inodes=452292,mode=755,gid=1000 0 0
/dev/block/dm-3 /data f2fs rw,lazytime,seclabel,nosuid,nodev,noatime,background_gc=on,discard,no_heap,user_xattr,inline_xattr,acl,inline_data,inline_dentry,flush_merge,extent_cache,mode=adaptive,active_logs=6,reserve_root=26387,resuid=0,resgid=1065,alloc_mode=default,fsync_mode=nobarrier 0 0
/dev/block/dm-0 /apex/com.android.media.swcodec@290000000 ext4 ro,seclabel,nodev,relatime 0 0
/dev/block/dm-0 /apex/com.android.media.swcodec ext4 ro,seclabel,nodev,relatime 0 0
/dev/block/dm-0 /apex/com.android.media@290000000 ext4 ro,seclabel,nodev,relatime 0 0
/dev/block/dm-0 /apex/com.android.media ext4 ro,seclabel,nodev,relatime 0 0
/dev/block/dm-0 /apex/com.android.resolv@290000000 ext4 ro,seclabel,nodev,relatime 0 0
/dev/block/dm-0 /apex/com.android.resolv ext4 ro,seclabel,nodev,relatime 0 0
/dev/block/dm-0 /apex/com.android.conscrypt@299900000 ext4 ro,seclabel,nodev,relatime 0 0
/dev/block/dm-0 /apex/com.android.conscrypt ext4 ro,seclabel,nodev,relatime 0 0
adb /dev/usb-ffs/adb functionfs rw,relatime 0 0
mtp /dev/usb-ffs/mtp functionfs rw,relatime 0 0
ptp /dev/usb-ffs/ptp functionfs rw,relatime 0 0
/data/media /mnt/runtime/default/emulated sdcardfs rw,nosuid,nodev,noexec,noatime,fsuid=1023,fsgid=1023,gid=1015,multiuser,mask=6,derive_gid,default_normal 0 0
/data/media /storage/emulated sdcardfs rw,nosuid,nodev,noexec,noatime,fsuid=1023,fsgid=1023,gid=1015,multiuser,mask=6,derive_gid,default_normal 0 0
/data/media /mnt/runtime/read/emulated sdcardfs rw,nosuid,nodev,noexec,noatime,fsuid=1023,fsgid=1023,gid=9997,multiuser,mask=23,derive_gid,default_normal 0 0
/data/media /mnt/runtime/write/emulated sdcardfs rw,nosuid,nodev,noexec,noatime,fsuid=1023,fsgid=1023,gid=9997,multiuser,mask=7,derive_gid,default_normal 0 0
/data/media /mnt/runtime/full/emulated sdcardfs rw,nosuid,nodev,noexec,noatime,fsuid=1023,fsgid=1023,gid=9997,multiuser,mask=7,derive_gid,default_normal 0 0
pstore /sys/fs/pstore pstore rw,seclabel,relatime 0 0

And the list of modules installed, as shown by ls during a failed boot is:

$ adb shell su - -c 'ls -lah /data/adb/modules/'
total 35K
drwxr-xr-x 23 root root 3.4K 2021-03-22 15:13 .
drwx------ 12 root root 3.4K 2021-03-22 17:14 ..
drwxr-xr-x  3 root root 3.4K 2021-01-12 14:46 Fdroid-Priv
drwxr-xr-x  5 root root 3.4K 2021-02-23 11:39 MagiskHidePropsConf
drwxr-xr-x  4 root root 3.4K 2021-01-12 20:16 acp
drwxr-xr-x  3 root root 3.4K 2021-02-23 11:39 adb-ndk
drwxr-xr-x  4 root root 3.4K 2021-03-22 17:14 aml
drwxr-xr-x  3 root root 3.4K 2021-02-23 11:39 busybox-ndk
drwxr-xr-x  3 root root 3.4K 2021-02-19 16:16 callrecorder-skvalex
drwxr-xr-x  3 root root 3.4K 2021-02-23 11:39 ccbins
drwxr-xr-x  4 root root 3.4K 2021-01-15 07:35 com.piyushgarg.rclone
drwxr-xr-x  3 root root 3.4K 2021-01-13 08:17 eds
drwxr-xr-x  3 root root 3.4K 2021-01-12 13:08 hosts
drwxr-xr-x  3 root root 3.4K 2021-03-06 04:56 microg_installer
drwxr-xr-x  5 root root 3.4K 2021-03-22 15:13 riru-core
drwxr-xr-x  4 root root 3.4K 2021-03-22 15:13 riru-sui
drwxr-xr-x  3 root root 3.4K 2021-02-23 11:23 riru_edxposed
drwxr-xr-x  3 root root 3.4K 2021-03-21 20:18 riru_storage_redirect
drwxr-xr-x  3 root root 3.4K 2021-01-22 15:40 safetynet-fix
drwxr-xr-x  2 root root 3.4K 2021-01-12 19:40 shizuku-starter
drwxr-xr-x  3 root root 3.4K 2021-01-13 06:41 ssh
drwxr-xr-x  4 root root 3.4K 2021-02-23 11:39 terminalmods
drwxr-xr-x  3 root root 3.4K 2021-02-23 11:39 zipsigner

When I tried to delete the "riru-core" and "riru-sui" folders above, they would rm successfully, but be there again on the next [failed] boot.

Please let me know what other information I can provide.

github-actions[bot] commented 3 years ago

This issue is being automatically closed because latest canary Magisk version code is 22005.