search

topjohnwu / Magisk

The Magic Mask for Android
GNU General Public License v3.0
47.68k stars 12.1k forks source link

22103 basicIntegrity & ctsProfile keep failing, even in external apps #4231

Closed coldarchie closed 3 years ago

coldarchie commented 3 years ago

Device: Nokia 6.1 Android version: 11 (LineageOS 18.1) Magisk version name: f49966d8 Magisk version code: 22103

After updating Magisk to 22103, basicIntegrity and ctsProfile keeps failing. I tried to toggle MagiskHide off and on, reinstall & uninstall all modules, but neither of these worked. Root works however. I did not have Xposed or something related to it and both ctsProfile and basicIntegrity were passing before the update. The only thing I modified is a single line in build.prop, but it was before the update.

Here are dmesg & Magisk logs: dmesg.log magisk.log

Screenshot_20210416-131032_Magisk Screenshot_20210416-125103_SafetyNet_Test

kearmau5 commented 3 years ago

I have 22100 and it is the same problem

osm0sis commented 3 years ago

Edit: Oh wait, misread. I see you're already on latest. 👍

osm0sis commented 3 years ago

@coldarchie Can you try this CI build instead? https://github.com/topjohnwu/Magisk/actions/runs/751925199

Download the artifact zip and install the debug apk.

kearmau5 commented 3 years ago

Can you try this CI build instead? https://github.com/topjohnwu/Magisk/actions/runs/751925199

I have a stable built 22100...what can i do to fix the safetynet issue

osm0sis commented 3 years ago

22100 it's just cosmetic and SafetyNet is still actually passing. 22103 report above sounds like something else since it also says it fails externally.

You can also update to the CI build if it bothers you that much.

osm0sis commented 3 years ago

For the record 22103 passes fine on my OP8T, so whatever it is for @coldarchie it's some kind of edge case, and odds are @kearmau5 would be fine on the latest released Canary as well.

kearmau5 commented 3 years ago

Screenshot_2021-04-16-13-20-48-202_hcr wo I have thoose modules installed Safety net used to pass despite having them or whitout

osm0sis commented 3 years ago

You clearly didn't listen to me at all. Stop derailing this issue.

kearmau5 commented 3 years ago

You clearly didn't listen to me at all. Stop derailing this issue.

Talk respectfully please and try to explain as easy We are not here to make this kind of slapping Say something could help or don't say anything No i wont switch to canary i used to work with stable with no issues until now

osm0sis commented 3 years ago

Edit: @kearmau5 @ndr48291 @Dev0110

I already told you everything you need to know: 1) It's only a cosmetic issue in stable, you actually still pass. 2) Latest Canary will fix it for you, it does for basically all others. 3) Your issue is different from this issue so you should not continue to post here.

Now, respectfully, if you refuse to be on Canary then you also shouldn't be in the Issues section here at all.

ghost commented 3 years ago

I made clean flash of DotOS rom on Mi 9T. Safetynet test fails in Magisk 22.1 but passes in Safetynet app. Netflix works fine. Phone works fine. Magisk hide is working.

Screenshot_20210416-124254 Screenshot_20210416-124324

kearmau5 commented 3 years ago

I made clean flash of DotOS rom on Mi 9T. Safetynet test fails in Magisk 22.1 but passes in Safetynet app. Netflix works fine. Phone works fine. Magisk hide is working.

Screenshot_20210416-124254 Screenshot_20210416-124324

Same here The app passes and magisk fails

osm0sis commented 3 years ago

Can you try this CI build instead? https://github.com/topjohnwu/Magisk/actions/runs/751925199

Download the artifact zip and install the debug apk.

@coldarchie please still try this and report back when able.

pndwal commented 3 years ago

Edit: Oh wait, misread. I see you're already on latest. 👍

Could this be related to modified build.prop user mentioned, or method used?

Guessing reverting and testing may be useful. PW

coldarchie commented 3 years ago

Can you try this CI build instead? https://github.com/topjohnwu/Magisk/actions/runs/751925199 Download the artifact zip and install the debug apk.

@coldarchie please still try this and report back when able.

Sorry for not paying attention on this issue, I needed Google Pay ASAP so I had to reflash my phone.

pndwal commented 3 years ago

Guess you mean reflashed with no custom mods & relocked bootloader?

Also, was buildprop change done systemlessly, or does r/w system work in LOS (seems no was mod used to restore r/w in Android 11)?

Just curious! 🙂

j0110 commented 3 years ago

The issue is still there... Can you reopen this issue?

coldarchie commented 3 years ago

Guess you mean reflashed with no custom mods & relocked bootloader?

Also, was buildprop change done systemlessly, or does r/w system work in LOS (seems no was mod used to restore r/w in Android 11)?

Just curious! 🙂

i had unlocked bootloader and i had to install busybox & magiskhide props to pass ctsprofile and i used some text editor & root to add ro.config.low_ram=true at the end of build.prop in /system/product/

osm0sis commented 3 years ago

So lifetime writes was > 0 on system.. That could explain it. Or just needed new MagiskHide Props. Either way I think we're resolved here if it's passing again with a reflash.

Anyone coming here and still complaining about SafetyNet check on latest stable, it's actually still passing (it's just the check that's broken), is different from this issue, and already fixed in Canary so use Canary or just wait.