Android P APIs for SU requests

topjohnwu / Magisk

The Magic Mask for Android

GNU General Public License v3.0

47.95k stars 12.17k forks source link

Android P APIs for SU requests #432

Closed Madis0 closed 5 years ago

Madis0 commented 6 years ago

I think that Magisk Manager should use the new authentication APIs for superuser requests if it is run on Android P.

For normal SU request, Android Protected Confirmation (article)
For biometrics-based SU request, unified biometric authentication (article)

The first would prevent more kinds of malware/hijacking and the second would let users use their face or iris alongside fingerprint to authenticate.

SuadMoh commented 6 years ago

Is SU reqest working fine?? or not ??? which script i can use in my app to have root permissiion???

topjohnwu commented 5 years ago

Currently, I have no idea how to integrate the new UI with superuser requests. Maybe one day if I'm too bored I'll think if there is a better way to rewrite the whole UI

Madis0 commented 5 years ago

The biometrics UI should be easier to implement as the OS provides it's own UI, FWIW.