topjohnwu / Magisk

The Magic Mask for Android
GNU General Public License v3.0
46.95k stars 11.86k forks source link

late_start happens too early #49

Closed josephcsible closed 7 years ago

josephcsible commented 7 years ago

On one of my devices (a Moto G "falcon" that's encrypted and running CM14.1), Magisk seems to be running late_start too early (specifically, before post-fs-data, so presumably before /data/magisk.img is accessible). This means it doesn't see or execute /magisk/phh/service.sh and root doesn't work. Log:

** Magisk post-fs mode running...
** Magisk late_start service mode running...
** Magisk post-fs-data mode running...
* Preparing modules
* Stage 1: Mount system and vendor mirrors
* Stage 2: Mount dummy skeletons
* Stage 3: Mount module items
* Stage 4: Execute module scripts
* Stage 5: Mount mirrored items back to dummy

Strangely, I can't reproduce this on any of my other devices despite setting them up the exact same way, and I can't make it stop happening on this device (I haven't tried wiping /data, but I've tried everything else).

josephcsible commented 7 years ago

This doesn't happen anymore. I'm not sure why it's fixed, but it is.