search

topjohnwu / Magisk

The Magic Mask for Android
GNU General Public License v3.0
47.6k stars 12.09k forks source link

Regression with zygisk denylist versus MagiskHide in v23 #5349

Closed Hr46ph closed 2 years ago

Hr46ph commented 2 years ago

Device: Oneplus 7t pro Android version: 12 Magisk version: 24100 Magisk version code: 24100

Previously, apps on the MagiskHide list were not denied access to modules, either from Magisk or xposed modules. More to the point, magisk could be hidden from an app while at the same time the effect of modules could be applied to them.

With Zygisk and the denylist, all magisk changes are reverted, which includes other zygisk modules. For example, using a module for a firewall won't apply firewall rules on an app that is on the denylist.

Personally I use several xposed modules (via lsposed zygisk) that I wish to apply on all user installed apps (firewall, xprivacylua). FOr some I also need to hide magisk from them or protect our privacy and access to our local network. Banking apps for which root often must be hidden, often also employ tracking, snoop location, read sensors and phone identifiers.

I think this is a serious regression from the previous versions with (albeit technically inferior, but working) MagiskHide.

MagiskBot commented 2 years ago

Invalid bug report, automatically closed. Please report issues using the latest canary Magisk version (version code: 24101).

Hr46ph commented 2 years ago

Will this stay closed because a bot believes I made a mistake, even though its a valid point and a serious regression?

Im not the only one.

pndwal commented 2 years ago

It's not a regression however, rather the way update JSON always points to latest stub (for hiding app) which always becomes incompatible after one or more updates....

My issue (mine wasn't the first either) got closed despite citing latest Canary, and blocked as off-topic! See here: https://github.com/topjohnwu/Magisk/issues/5382

I would have posted workarounds there, but had to continue issue privately here: https://github.com/pndwal/Jsons/issues/1#issuecomment-1031844800

See XDA link for work raw JSON addressed for custom channel, and workaround for recent builds there. 👍