search

topjohnwu / Magisk

The Magic Mask for Android
GNU General Public License v3.0
47.6k stars 12.08k forks source link

[Feature Request] Native Backup And Restore Function For Superuser and Deny Lists #6543

Closed stylemessiah closed 1 year ago

stylemessiah commented 1 year ago

As someone who has at times tested up to 5 ROMS a week in times past, having the ability to easily backup and restore the contents of the Superuser and Deny lists are an obvious timesaver, and so i first created modules to backup Magiskhide (i know this has been removed from official, and why) or Deny lists some time ago, just recently, before xmas i added modules to backup and restore Superuser lists (something id been meaning to get around to for a while, and prompted into action by a user query about it).

Currently i have modules that do these jobs:

Superuser: https://github.com/stylemessiah/SuperuserListBackup https://github.com/stylemessiah/SuperuserListRestore

Magiskhide/Deny List: https://github.com/stylemessiah/MagiskHideDenyBackup https://github.com/stylemessiah/MagiskHideDenyRestore

Im just adding this feature request to judge the interest for native support for this function in the Magisk Manager app itself

I beleive it would be useful to users

Device: Pixel 6 Pro Android version: 13 Magisk version name: Debug Magisk version code: 25206

vvb2060 commented 1 year ago

cp /data/adb/magisk.db

stylemessiah commented 1 year ago

cp /data/adb/magisk.db

yes, we are aware this is possible, but not a very fucntional or safe method especially if people switch between magisk forks, or database schema changes.... and we have had database schema changes in the past...which is exactly why i stopped doing what you proposed in your short reply, and made my module magisk fork agnostic as it was far safer to use flat file backup and restore...

vvb2060 commented 1 year ago

After asking internally, we have no interest in implementing this feature.

ipdev99 commented 1 year ago

This just seems silly to me not to include a backup/restore of settings/configuration.

Most apps have included this option for some time. Often it is just a simple json file.

I do not understand why Magisk (internally) would not want to offer users an official way of backing up and restoring settings?

Instead you are willing to allow users to use third-party or blaze their own path on backup and restoring their settings. Just because the option is officially included in Magisk, does not mean the user would have to use it. They could still use a third-party option, use their own path or just waste the time to manually set everything up again after a clean install.

Cheers. :cowboy_hat_face: