search

topjohnwu / Magisk

The Magic Mask for Android
GNU General Public License v3.0
46.85k stars 11.81k forks source link

Canary debug app can't update itself due to exceeding 20MB #8212

Closed osm0sis closed 1 month ago

osm0sis commented 1 month ago

Device: Pixel 8 Pro Android version: 14 (Stock) Magisk version name: b38ab2a7 Magisk version code: 27004

Log excerpt:

07-14 00:39:56.041  9741 13714 I okhttp.OkHttpClient: --> GET https://cdn.jsdelivr.net/gh/topjohnwu/magisk-files@ad9ae1442af88b56cf382f987624d823b897a72a/notes.md
07-14 00:39:56.060  9741 13714 I okhttp.OkHttpClient: <-- 200 https://cdn.jsdelivr.net/gh/topjohnwu/magisk-files@ad9ae1442af88b56cf382f987624d823b897a72a/notes.md (18ms, unknown-length body)
07-14 00:39:56.099  9741  9741 W TextView: onProvideContentCaptureStructure(): calling assumeLayout()
07-14 00:39:56.099  9741  9741 W TextView: onProvideContentCaptureStructure(): calling assumeLayout()
07-14 00:39:56.100  9741  9741 W TextView: onProvideContentCaptureStructure(): calling assumeLayout()
07-14 00:39:57.115  9741  9741 W WindowOnBackDispatcher: sendCancelIfRunning: isInProgress=falsecallback=android.view.ViewRootImpl$$ExternalSyntheticLambda11@a5eddd9
07-14 00:39:57.125  9741 11748 D HWUI    : endAllActiveAnimators on 0xb4000070f4739700 (RippleDrawable) with handle 0xb400007264776920
07-14 00:39:57.260  9741 13714 I okhttp.OkHttpClient: --> GET https://cdn.jsdelivr.net/gh/topjohnwu/magisk-files@ad9ae1442af88b56cf382f987624d823b897a72a/app-debug.apk
07-14 00:39:57.355  9741 13714 D TrafficStats: tagSocket(145) with statsTag=0xffffffff, statsUid=-1
07-14 00:39:57.810  9741 13714 I okhttp.OkHttpClient: <-- 403 https://cdn.jsdelivr.net/gh/topjohnwu/magisk-files@ad9ae1442af88b56cf382f987624d823b897a72a/app-debug.apk (549ms, 49-byte body)
07-14 00:39:57.812  9741  9821 D CompatibilityChangeReporter: Compat change id reported: 247079863; UID 10434; state: ENABLED
07-14 00:39:57.813  9741  9821 E DownloadEngine$download: java.io.IOException: retrofit2.HttpException: HTTP 403 
07-14 00:39:57.813  9741  9821 E DownloadEngine$download:   at com.topjohnwu.magisk.core.repository.NetworkService.fetchFile(NetworkService.kt:82)
07-14 00:39:57.813  9741  9821 E DownloadEngine$download:   at com.topjohnwu.magisk.core.repository.NetworkService$fetchFile$1.invokeSuspend(Unknown Source:15)
07-14 00:39:57.813  9741  9821 E DownloadEngine$download:   at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
07-14 00:39:57.813  9741  9821 E DownloadEngine$download:   at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
07-14 00:39:57.813  9741  9821 E DownloadEngine$download:   at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:115)
07-14 00:39:57.813  9741  9821 E DownloadEngine$download:   at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:103)
07-14 00:39:57.813  9741  9821 E DownloadEngine$download:   at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:584)
07-14 00:39:57.813  9741  9821 E DownloadEngine$download:   at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:793)
07-14 00:39:57.813  9741  9821 E DownloadEngine$download:   at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:697)
07-14 00:39:57.813  9741  9821 E DownloadEngine$download:   at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:684)
07-14 00:39:57.813  9741  9821 E DownloadEngine$download: Caused by: retrofit2.HttpException: HTTP 403 
07-14 00:39:57.813  9741  9821 E DownloadEngine$download:   at retrofit2.KotlinExtensions$await$2$2.onResponse(KotlinExtensions.kt:53)
07-14 00:39:57.813  9741  9821 E DownloadEngine$download:   at retrofit2.OkHttpCall$1.onResponse(OkHttpCall.java:164)
07-14 00:39:57.813  9741  9821 E DownloadEngine$download:   at okhttp3.internal.connection.RealCall$AsyncCall.run(RealCall.kt:519)
07-14 00:39:57.813  9741  9821 E DownloadEngine$download:   at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
07-14 00:39:57.813  9741  9821 E DownloadEngine$download:   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644)
07-14 00:39:57.813  9741  9821 E DownloadEngine$download:   at java.lang.Thread.run(Thread.java:1012)

Attempting to manually go to https://cdn.jsdelivr.net/gh/topjohnwu/magisk-files@ad9ae1442af88b56cf382f987624d823b897a72a/app-debug.apk gives the error: File size exceeded the configured limit of 20 MB.

The app has indeed crept from 18.8mb to 22mb in the last few debug canaries.

Originally posted by @osm0sis in https://github.com/topjohnwu/Magisk/issues/8208#issuecomment-2226995110

vvb2060 commented 1 month ago

from 12mb to 22mb in the last few debug canaries.

12MiB debug build?

osm0sis commented 1 month ago

from 12mb to 22mb in the last few debug canaries.

12MiB debug build?

Edited, 18.8. 👍

SoumilSehgal commented 1 month ago

Did you manage to update it?

osm0sis commented 1 month ago

It's easy, just go download it directly and update it. It's not limited like jsdelivr.

https://github.com/topjohnwu/magisk-files/blob/canary/app-debug.apk